TC in CIccTagXmlTagData::ToXml() at IccXML/IccLibXML/IccTagXml.cpp:1730:7

[xsscx]

Maintainer Repro

Wed Dec 31 07:11:59 PM UTC 2025

Git

git rev-parse HEAD && git show --no-patch --oneline
b656e80

HOST

Linux 6.6.87.2-microsoft-standard-WSL2 #1 SMP PREEMPT_DYNAMIC Thu Jun 5 18:30:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Step 1. wget https://github.com/xsscx/Commodity-Injection-Signatures/raw/refs/heads/master/graphics/icc/ub-icDataBlockType-IccTagBasic_h-L1299.icc

Step 2. iccToXml ub-icDataBlockType-IccTagBasic_h-L1299.icc ub-icDataBlockType-IccTagBasic_h-L1299.xml

Expected Output

IccLibXML/IccTagXml.cpp:1730:7: runtime error: load of value 16777216, which is not a valid value for type 'icDataBlockType'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior IccXML/IccLibXML/IccTagXml.cpp:1730:7
XML successfully created

[ChrisCoxArt]

Same basic issue as #392 - the type needs a size and range.
Hmm, and comparing against 1 ignores future types, and compression. Better test the bit instead of a value.