ouroboros-network-api: RemoteAddress encoding

Polymorphic over version, we need it in both `dmq-node` and
`cardano-diffusion`.

Author: coot

dmq-node/app/Main.hs

@@ -34,7 +34,8 @@ import DMQ.Diffusion.Arguments
 import DMQ.Diffusion.NodeKernel (mempool, withNodeKernel)
 import DMQ.Handlers.TopLevel (toplevelExceptionHandler)
 import DMQ.NodeToClient qualified as NtC
-import DMQ.NodeToNode (dmqCodecs, dmqLimitsAndTimeouts, ntnApps)
+import DMQ.NodeToNode (NodeToNodeVersion, dmqCodecs, dmqLimitsAndTimeouts,
+           ntnApps)
 import DMQ.Protocol.LocalMsgSubmission.Codec
 import DMQ.Protocol.SigSubmission.Type (Sig (..))
 import DMQ.Tracer
@@ -122,10 +123,8 @@ runDMQ commandLineConfig = do
                     dmqConfig
                     nodeKernel
                     (dmqCodecs
-                              -- TODO: `maxBound :: Cardano.Network.NodeToNode.NodeToNodeVersion`
-                              -- is unsafe here!
-                               (encodeRemoteAddress maxBound)
-                               (decodeRemoteAddress maxBound))
+                       (encodeRemoteAddress (maxBound @NodeToNodeVersion))
+                       (decodeRemoteAddress (maxBound @NodeToNodeVersion)))
                     dmqLimitsAndTimeouts
                     defaultSigDecisionPolicy
           dmqNtCApps =

ouroboros-network-api/src/Ouroboros/Network/PeerSelection/PeerSharing/Codec.hs

@@ -11,7 +11,6 @@ import Codec.CBOR.Decoding qualified as CBOR
 import Codec.CBOR.Encoding qualified as CBOR
 
 import Network.Socket (PortNumber, SockAddr (..))
-import Ouroboros.Network.NodeToNode.Version (NodeToNodeVersion (..))
 
 encodePortNumber :: PortNumber -> CBOR.Encoding
 encodePortNumber = CBOR.encodeWord16 . fromIntegral
@@ -27,7 +26,7 @@ decodePortNumber = fromIntegral <$> CBOR.decodeWord16
 ---
 -- /Invariant:/ not a unix socket address type.
 ---
-encodeRemoteAddress :: NodeToNodeVersion -> SockAddr -> CBOR.Encoding
+encodeRemoteAddress :: version -> SockAddr -> CBOR.Encoding
 encodeRemoteAddress _ = \case
   SockAddrInet pn w -> CBOR.encodeListLen 3
                     <> CBOR.encodeWord 0
@@ -47,7 +46,7 @@ encodeRemoteAddress _ = \case
 --
 -- See the network design document for more details
 --
-decodeRemoteAddress :: NodeToNodeVersion -> CBOR.Decoder s SockAddr
+decodeRemoteAddress :: version -> CBOR.Decoder s SockAddr
 decodeRemoteAddress _ = do
   _ <- CBOR.decodeListLen
   tok <- CBOR.decodeWord