Skip to content

Bug: GO Api keeps the train that already departed in "Incoming Vehicles" #63

@jacqnnn

Description

@jacqnnn

Description

  1. We are fetching Incoming Vehicles Information from GO Api Stop/NextService enpoint. However, the endpoint will keep the "already departed" trains for 3-5 minutes before they disappear in this api call. Thus, the already departed trains are technically NOT "Incoming Vehicles".
    Ran main.java at 13:47, while the train that departed at 13:44:27 is still in the API.
    image

  2. The Stop/NextService API endpoint becomes inaccurate when there is an arbitrary service update.
    For example: the Stop/NextService endpoint at 2023-12-02 14:10 will keep the vehicle that is supposedly to depart at 2023-12-02 13:57, but it's not shown on the GO website since there's a service update.
    image
    image
    image
    The service update is included in ServiceUpdate/ServiceAlert endpoint and the affected train schedule is updated in ServiceUpdate/Exceptions/Train enpoint, while the Stop/NextService is not updated.

Expected behaviour

[ What was supposed to happen instead? ]

Reproduction steps

[ List steps on how to reproduce the bug in point form. Add screenshots where desirable ]

Additional details

  1. The first problem: GO Api keeping departed trains might be because:
    • Latency
      • If the issue is caused by pure latency, we might compare the computed departure time to 'now' and not show the trains that already departed
    • Computed Departure Time is off, and the train hasn't departed yet.
      • If the computed departure time is off, then this is a problem yet to be solved.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions