Skip to content

Bugs with SHMS template files #222

@ghost

Description

pstackana.template:

  1. For the hodoscope, there is a variable called "pCleanTrack" as well as "1pCleanTrack", "2pCleanTrack", "3pCleanTrack" and "4pCleanTrack". I don't think that 2p,3p,4p are being properly calculated because they're all = 0, but 1pCleanTrack is filled. pCleanTrack is just the sum of 1p,2p,3p,4p so pCleanTrack=1pCleanTrack. pFoundTrack appears to be working correctly.
  2. Both the HGC and NGC are in the template, and I basically copied the "preamble" to the original cerenkov from the 6GeV era and edited the variables in order to describe what constitutes as "good tracks". The preamble isn't all that descriptive to me so perhaps we can make it more descriptive.
  3. I didn't put in an aerogel "preamble" on what constitutes a good track yet, mostly because I think there might be a small problem with the code. I used the same formatting for the aerogel cerenkov as the previous ceres, but it seems as though only the very first array for fired and matched is getting filled as all subsequent regions are returning 0 except for the first one.
  4. I saw that there are two lines pertaining to the calorimeter efficiency now in the report file. The previous generation of the report file actually had efficiency per block (11 blocks) and then an effective efficiency for the entire block (4 blocks). I know that the SHMS calorimeter is handled differently, but are these two lines the only things that we need in this case? Won't it be different for the HMS?
  5. In order to get the hodoscope efficiency, you need to add the module to the script. When I do that and replay a run I would see where the module would initiate and it would print out the following
    "Plane 1 counters d
    Plane 2 counters d
    Plane 3 counters e
    Plane 4 counters 15"
    and then soon after it would crash. So I went into the HodoEff code and threw in a few print statements where I assumed that all variables were integers and found a compiler warning where fPlanes[ip] actually has type THcScintillatorPlane instead of an integer which I thought was kind of weird. Maybe it's nothing but I'll do some more poking around to see what I can come up with because for now the module just won't work so I haven't written the actual pos/neg/or/and efficiencies yet.
  6. There are several things such as "raw", "good", "real" (etc) that may possibly need more description. I only wrote an efficiency for the "good" DC. It's trivial to add efficiency for the other two if I need to.
  7. There are still several compiler errors I get pertaining to T.shms.pFRXA_adcPulseIntRaw etc...

pscalers.template:

  1. This wasn't added by me but "Accepted SHMS triggers" reports 0, as does everything under EDTM.
  2. Hodoscope planes X1,X2,Y1, all appear normal, but Y2 is extremely weird. Y2 the + PMTs 1-16 report 0 while 17-21 return nonsense because in db_PSScale.vt they don't exist, and for the - PMTs 1-6 return 0, 7-15 return a number, 16 returns 0, 17-21 return nonsense because they're also not in the .vt file.
  3. I added the scaler/scalerrate for the aero, hgc, and ngc, but the numbers look a bit wonky.

After we get these issues figured out I'll combine pstackana.template and pscalers.template into pstackana_production.template.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions