-
-
Notifications
You must be signed in to change notification settings - Fork 12
Description
Describe the bug
During automatic metadata download after importing games, I get multiple errors that say "Error fetching Xbox metadata: One or more errors occurred." With 475+ games, it will always happen multiple times during the entire process. If I dismiss the error during download, it will reoccur. With a smaller set of games, it is possible the error won't occur. It only happens on some games, and not others.
To Reproduce
Install Xbox Metadata, and configure any field(s) to use it during automatic metadata download in Playnite Settings. It can be 1 field, or all fields, it doesn't matter - every field causes the errors (text or image fields). This leads me to believe it is having trouble downloading any data for some games, not just certain fields. The extension settings are defaults.
Use a large enough sample of games to increase odds of error occurring. I have noticed the errors always seem to start occurring at around the same # of games into the process, so I think it is reproducible for certain games.
Expected behavior
Expectation is that no errors are generated during metadata download, like most other metadata providers don't. If the error is indicating no data could be found for the game, just return nothing so that the next source in order for that field can try to get data instead, and generate no notification errors in Playnite. I see no reason to show the user these errors, but you could make it a setting in the extension if you want.
Note: Ignore the MetadataLocal error in the screenshot, it isn't relevant - I was just testing both. These errors occur without MetadataLocal even installed, and just using Xbox Metadata alone. You will notice that "MetadataLocal" doesn't even occur in the attached log file, as I was not using it when generating the log.
Extensions log
attach.zip (also includes extension config.json)
Note: I noticed there are at least 2 errors in the .log file when searching for the word "fetch":
- Error fetching Xbox data: HttpRequestException: Error while copying content to a stream
- Error fetching Xbox data: ArgumentNullException: Value cannot be null
Versions used
Playnite: 10.35
SDK: 6.11.0
Xbox Metadata: 0.3.3
