Open
Conversation
Ayantea1
reviewed
Aug 8, 2025
| ['Восточный экспресс', 'Детективы'] | ||
| ] | ||
| ) | ||
| def test_get_book_genre_by_name_success(self, name, genre, collector): |
There was a problem hiding this comment.
Нужно исправить: тест все еще не отличается от теста установки жанра. Нужно либо не использовать в этом тесте set метод, либо сравнивать с содержимым словаря
Ayantea1
reviewed
Aug 8, 2025
| # проверяем, что добавилось именно две | ||
| # словарь books_rating, который нам возвращает метод get_books_rating, имеет длину 2 | ||
| assert len(collector.get_books_rating()) == 2 | ||
| def test_get_list_of_favorites_books_success(self, collector): |
There was a problem hiding this comment.
Нужно исправить: тест аналогичен тесту добавления в избранное. Тут нужно проверить, что возвращается именно нужный список. Метод добавления в список можно не использовать, а создать его напрямую
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добрый день. Внесены изменения в соответствии с твоими замечаниями, поправлены отдельные тесты