OffsetArray device should be that of parent's.

Author: chriselrod

Project.toml

@@ -1,6 +1,6 @@
 name = "ArrayInterface"
 uuid = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
-version = "2.14.4"
+version = "2.14.5"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/ArrayInterface.jl

@@ -889,7 +889,7 @@ function __init__()
       strides(A::OffsetArrays.OffsetArray) = strides(parent(A))
       # offsets(A::OffsetArrays.OffsetArray) = map(+, A.offsets, offsets(parent(A)))
       parent_type(::Type{O}) where {T,N,A<:AbstractArray{T,N},O<:OffsetArrays.OffsetArray{T,N,A}} = A
-      device(::Type{<:OffsetArrays.OffsetArray}) = CheckParent()
+      device(::Type{A}) where {A <: OffsetArrays.OffsetArray} = device(parent_type(A))
       contiguous_axis(::Type{A}) where {A <: OffsetArrays.OffsetArray} = contiguous_axis(parent_type(A))
       contiguous_batch_size(::Type{A}) where {A <: OffsetArrays.OffsetArray} = contiguous_batch_size(parent_type(A))
       stride_rank(::Type{A}) where {A <: OffsetArrays.OffsetArray} = stride_rank(parent_type(A))

test/runtests.jl

@@ -263,6 +263,7 @@ DummyZeros(dims...) = DummyZeros{Float64}(dims...)
 Base.size(x::DummyZeros) = x.dims
 Base.getindex(::DummyZeros{T}, inds...) where {T} = zero(T)
 
+using OffsetArrays
 @testset "Memory Layout" begin
     A = zeros(3,4,5);
     D1 = view(A, 1:2:3, :, :)  # first dimension is discontiguous
@@ -272,12 +273,12 @@ Base.getindex(::DummyZeros{T}, inds...) where {T} = zero(T)
     @test @inferred(device(PermutedDimsArray(A,(3,1,2)))) === ArrayInterface.CPUPointer()
     @test @inferred(device(view(A, 1, :, 2:4))) === ArrayInterface.CPUPointer()
     @test @inferred(device(view(A, 1, :, 2:4)')) === ArrayInterface.CPUPointer()
-    @test @inferred(device(view(PermutedDimsArray(A, (3,1,2)), 1, :, 2:4)')) === ArrayInterface.CPUPointer()
-    @test @inferred(device(view(A, 1, :, [2,3,4]))) === ArrayInterface.CPUIndex()
-    @test @inferred(device(view(A, 1, :, [2,3,4])')) === ArrayInterface.CPUIndex()
-    @test @inferred(device(@SArray(zeros(2,2,2)))) === ArrayInterface.CPUIndex()
-    @test @inferred(device(@view(@SArray(zeros(2,2,2))[1,1:2,:]))) === ArrayInterface.CPUIndex()
-    @test @inferred(device(@MArray(zeros(2,2,2)))) === ArrayInterface.CPUPointer()
+    @test @inferred(device(OffsetArray(view(PermutedDimsArray(A, (3,1,2)), 1, :, 2:4)', 3, -173))) === ArrayInterface.CPUPointer()
+    @test @inferred(device(view(OffsetArray(A,2,3,-12), 4, :, -11:-9))) === ArrayInterface.CPUPointer()
+    @test @inferred(device(view(OffsetArray(A,2,3,-12), 3, :, [-11,-10,-9])')) === ArrayInterface.CPUIndex()
+    @test @inferred(device(OffsetArray(@SArray(zeros(2,2,2)),-123,29,3231))) === ArrayInterface.CPUIndex()
+    @test @inferred(device(OffsetArray(@view(@SArray(zeros(2,2,2))[1,1:2,:]),-3,4))) === ArrayInterface.CPUIndex()
+    @test @inferred(device(OffsetArray(@MArray(zeros(2,2,2)),8,-2,-5))) === ArrayInterface.CPUPointer()
     @test isnothing(device("Hello, world!"))
 
     @test @inferred(contiguous_axis(@SArray(zeros(2,2,2)))) === ArrayInterface.Contiguous(1)
@@ -360,7 +361,6 @@ Base.getindex(::DummyZeros{T}, inds...) where {T} = zero(T)
     @test collect(strides(B))[collect(stride_rank(doubleperm))] == collect(strides(doubleperm))
 end
 
-using OffsetArrays
 @testset "Static-Dynamic Size, Strides, and Offsets" begin
     A = zeros(3,4,5); Ap = @view(PermutedDimsArray(A,(3,1,2))[:,1:2,1])';
     S = @SArray zeros(2,3,4); Sp = @view(PermutedDimsArray(S,(3,1,2))[2:3,1:2,:]);