fix copy for views (#170)

* fix copy for views

* do not recurse

* comment

* avoid eachcol in tests

Author: Pietro Vertechi

src/structarray.jl

@@ -398,7 +398,7 @@ for op in [:cat, :hcat, :vcat]
     end
 end
 
-Base.copy(s::StructArray{T,N,C}) where {T,N,C} = StructArray{T,N,C}(C(copy(x) for x in components(s)))
+Base.copy(s::StructArray{T}) where {T} = StructArray{T}(map(copy, components(s)))
 
 function Base.reshape(s::StructArray{T}, d::Dims) where {T}
     StructArray{T}(map(x -> reshape(x, d), components(s)))

test/runtests.jl

@@ -278,6 +278,14 @@ end
     t2[1,1] = 2.0 + im*4.0
     # Test we actually did a copy
     @test t[1,1] == 1.0 + im*4.0
+    # Test that `copy` works, even when the array type changes (e.g. views)
+    s = rand(10, 2)
+    v = StructArray{ComplexF64}((view(s, :, 1), view(s, :, 2)))
+    v2 = copy(v)
+    @test v2.re isa Vector
+    @test v2.im isa Vector
+    @test v2.re == copy(v.re)
+    @test v2.im == copy(v.im)
 end
 
 @testset "undef initializer" begin