-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Description
First, thanks a lot for the package! It's great.
I've started using it, and one thing that would be useful for me is to allow the orbitals to be empty.
Typically, when considering x-ray physics, it's not impossible to have empty core orbitals. It is nice to keep track of them, because electrons from other orbitals can decay into the empty ones, and it simplifies the interfacing with external code that actually compute the electronic structure.
Then, probably, it would be nice to have few more utility function e.g. to get the highest occupied orbital, which could no longer be assumed to be config[end].
I can make a PR this week if it sounds like a good idea.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels