svd! fails on nightly test

[andreasvarga]

I prepared an (almost) generic version of the MatrixPencils.jl package. The LTS and v1.11 tests are OK, but the nighly test fails with errors like the following one (see here):

sklf_left! - standard case: Error During Test at /home/runner/work/MatrixPencils.jl/MatrixPencils.jl/test/test_sklf.jl:979
  Got exception outside of a @test
  MethodError: no method matching svd!(::Matrix{BigFloat}; full::Bool, alg::LinearAlgebra.DivideAndConquer, atol::Int64, rtol::Int64)
  This method does not support all of the given keyword arguments (and may not support any).
  Closest candidates are:
    svd!(::StridedMatrix{T}; tol, full, alg) where T got unsupported keyword arguments "atol", "rtol"
     @ GenericLinearAlgebra ~/.julia/packages/GenericLinearAlgebra/jlOvW/src/svd.jl:635
    svd!(::LinearAlgebra.Bidiagonal{var"#s5110", V} where {var"#s5110"<:Union{Float32, Float64}, V<:AbstractVector{var"#s5110"}}; full) got unsupported keyword arguments "alg", "atol", "rtol"
     @ LinearAlgebra /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.13/LinearAlgebra/src/bidiag.jl:268
    svd!(::LinearAlgebra.Bidiagonal{T, V} where V<:AbstractVector{T}; tol, full, alg) where T<:Real got unsupported keyword arguments "atol", "rtol"
     @ GenericLinearAlgebra ~/.julia/packages/GenericLinearAlgebra/jlOvW/src/svd.jl:595

Stacktrace:
    [1] kwerr(::@NamedTuple{full::Bool, alg::LinearAlgebra.DivideAndConquer, atol::Int64, rtol::Int64}, ::Function, ::Matrix{BigFloat})
      @ Base ./error.jl:175
    [2] kwcall(::@NamedTuple{full::Bool, alg::LinearAlgebra.DivideAndConquer, atol::Int64, rtol::Int64}, ::typeof(LinearAlgebra.svd!), A::Matrix{BigFloat})
      @ GenericLinearAlgebra ~/.julia/packages/GenericLinearAlgebra/jlOvW/src/svd.jl:635
    [3] svd(A::Matrix{BigFloat}; full::Bool, alg::LinearAlgebra.DivideAndConquer, atol::Int64, rtol::Int64)
      @ LinearAlgebra /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.13/LinearAlgebra/src/svd.jl:194
    [4] kwcall(::@NamedTuple{full::Bool}, ::typeof(LinearAlgebra.svd), A::Matrix{BigFloat})
      @ LinearAlgebra /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.13/LinearAlgebra/src/svd.jl:193

I assume there is an incompatibility in the interface with the future version of the LinearAlgebra.jl package. Is any chance to fix this issue before version v1.12 of Julia is released?

[araujoms]

That's fixed by #160. Note that there is no problem with 1.12, the keyword argument was introduced in 1.13.

[andreasnoack]

Notice that we also test on prereleases ('pre') here, so we'd detect the issue here in time, provided that something triggers CI during the prerelease period. I'll see if I can set up a cron CI job to run monthly to ensure this.

Update: Done in 77e92ac

[andreasvarga]

I performed the tests on the prerelease (i.e.v1.12) with success. Thanks for hinting to this. I will reactivate the nightly test after the mentioned PR will be merged.

[araujoms]

@andreasnoack This issue should have been closed as #160 was merged.