Skip to content

Commit f7dc713

Browse files
authored
Let length(::SparseVector{Tv,Ti}) return Ti (#176) (#262)
1 parent d9a9e95 commit f7dc713

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/sparsevector.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ const AdjOrTransSparseVectorUnion{Tv,Ti} = LinearAlgebra.AdjOrTrans{Tv, <:Sparse
4040

4141
### Basic properties
4242

43+
length(x::SparseVector) = getfield(x, :n)
4344
size(x::SparseVector) = (getfield(x, :n),)
4445
count(f, x::SparseVector) = count(f, nonzeros(x)) + f(zero(eltype(x)))*(length(x) - nnz(x))
4546

test/sparsevector.jl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,12 @@ x1_full[SparseArrays.nonzeroinds(spv_x1)] = nonzeros(spv_x1)
3333
@test SparseArrays.nonzeroinds(x) == [2, 5, 6]
3434
@test nonzeros(x) == [1.25, -0.75, 3.5]
3535
@test count(SparseVector(8, [2, 5, 6], [true,false,true])) == 2
36-
y = SparseVector(typemax(Int128), Int128[4], [5])
36+
y = SparseVector(8, Int128[4], [5])
3737
@test y isa SparseVector{Int,Int128}
38-
@test @inferred size(y) == (@inferred(length(y)),)
38+
@test @inferred size(y) == (@inferred(length(y))::Int128,)
39+
y = SparseVector(8, Int8[4], [5.0])
40+
@test y isa SparseVector{Float64,Int8}
41+
@test @inferred size(y) == (@inferred(length(y))::Int8,)
3942
end
4043

4144
@testset "isstored" begin

0 commit comments

Comments
 (0)