Lag Issues?

[bobhenl]

Hello, isn't there unnecessary high CPU usage & packets usage by the AdvancedReplay, cannot it be done more async, or so?

https://spark.lucko.me/swtqyZprsb

Started: Sun Mar 23 20:16:46 UTC 2025
Stopped: Sun Mar 23 20:34:39 UTC 2025 (after 1072 seconds)
=== PLUGIN AdvancedReplay ===
 TYPE: SYNC_INBOUND 
 -------------------------------------------------------------------------------------------------------------------------------------------
 Protocol:      Name:                         Count:       Min (ms):       Max (ms):       Mean (ms):      Std (ms): 
 -------------------------------------------------------------------------------------------------------------------------------------------
 PLAY           POSITION                      107013       0.000020        14.178182       0.000906        0.044423 
 PLAY           POSITION_LOOK                 121940       0.000020        11.065998       0.000998        0.033999 
 PLAY           LOOK                          28862        0.000020        0.696603        0.000693        0.005822 
 PLAY           BLOCK_DIG                     27383        0.000020        1.601705        0.001037        0.010394 
 PLAY           ENTITY_ACTION                 13392        0.000020        5.982883        0.003319        0.056380 
 PLAY           ARM_ANIMATION                 36654        0.000020        7.430090        0.000511        0.038868 
 SUM            -                             335244       0.000020        14.178182       0.000985        0.036800 
 -------------------------------------------------------------------------------------------------------------------------------------------
 TYPE: SYNC_OUTBOUND 
 -------------------------------------------------------------------------------------------------------------------------------------------
 Protocol:      Name:                         Count:       Min (ms):       Max (ms):       Mean (ms):      Std (ms): 
 -------------------------------------------------------------------------------------------------------------------------------------------
 PLAY           SPAWN_ENTITY                  94012        0.000010        2.477257        0.001790        0.016894 
 PLAY           EXPLOSION                     600          0.000020        4.351829        0.023683        0.197102 
 PLAY           REL_ENTITY_MOVE               1924845      0.000010        2.880817        0.000103        0.002495 
 PLAY           REL_ENTITY_MOVE_LOOK          586999       0.000010        2.274303        0.000160        0.003410 
 PLAY           ENTITY_LOOK                   114953       0.000010        2.201940        0.000105        0.006523 
 PLAY           POSITION                      1028         0.000020        0.005910        0.000356        0.000452 
 PLAY           ENTITY_DESTROY                111887       0.000010        1.718424        0.000620        0.008476 
 PLAY           ENTITY_VELOCITY               2720683      0.000010        38.326908       0.000124        0.024556 
 PLAY           ENTITY_TELEPORT               2553         0.000020        0.056239        0.000185        0.001325 
 SUM            -                             5557560      0.000010        38.326908       0.000161        0.017606 
 => Time on main thread: 895.074230 ms
 -------------------------------------------------------------------------------------------------------------------------------------------

[Jumper251]

From looking at your profiler results it does not really look like AdvancedReplay would cause any lags or problems.
I am not sure if it is worth it to optimize more stuff for ProtocolLib right now since I might migrate the plugin to use PacketEvents in the future.

[bobhenl]

yeah I agree it would be better to use PacketEvents than protocollib

But if you can try to optimize some parts of the code it would be great!

[bobhenl]

https://spark.lucko.me/ipVpIiW1rc
@Jumper251 looks like some issue as well even with new update