Library unmaintained and all kind of broken

[ytti]

1. you need XML header, yet you specifically repeatedly call #root to get rid of it
2. you treat hello as special case, instead of as part call utilising normal infrastructure, so it's missing MSG_END

Simple:

Netconf::SSH.new(login) do |nc|
  cfgall = nc.rpc.get_config
  puts cfgall
end

Won't work against latest IOS-XE (16.4.1), due to above errors.

On more larger infrastructure/design view:

1. you should not call Nokogiri over once, you should wrap it on you own decorator so you can fix your code in single place
2. you should not rely #send_and_receive to append the MSG_END this should be added by send function only, so commands which do not expect/want to receive data are still correctly appended by MSG_END
3. all and all, it is seems POC/unmaintained/not_idiomatic, would be grand if Juniper would invest some time on money on it, I'm sure customer would enjoy it.

I do not propose fixing the 1/2, I propose redesign/refactor.

Thanks!

[dgjnpr]

thanks @ytti

I'm breathing new life into this project. Hopefully that will resolve point 3. For points 1 & 2 I agree that a refactor is required. But before that I want to setup CI so that we don't (seriously) break working existing behaviour

[tarko]

+1, got hit with the malformatted HELLO on Timos