Skip to content

Conversation

@ceelias
Copy link
Contributor

@ceelias ceelias commented Aug 31, 2022

@mdaum mdaum self-requested a review September 1, 2022 15:20
mdaum
mdaum previously approved these changes Sep 1, 2022
package-name: 'jupiterone/graph-kubernetes'
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
push-to-registry: 'true'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could use a boolean here instead of a string. Thoughts @ceelias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that was my initial intent but its not supported unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants