From 07a914272ad1beecca60ede3fc72db1513d7d25c Mon Sep 17 00:00:00 2001 From: zeng-github01 <95841646+zeng-github01@users.noreply.github.com> Date: Sun, 29 Mar 2026 10:19:32 +0800 Subject: [PATCH 1/2] Fix pEffect legacy Compatibility --- src/main/java/noppes/npcs/VersionCompatibility.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/java/noppes/npcs/VersionCompatibility.java b/src/main/java/noppes/npcs/VersionCompatibility.java index 98dd6c20e..e468c0174 100644 --- a/src/main/java/noppes/npcs/VersionCompatibility.java +++ b/src/main/java/noppes/npcs/VersionCompatibility.java @@ -4,6 +4,7 @@ import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagInt; import net.minecraft.nbt.NBTTagList; +import noppes.npcs.constants.EnumPotionType; import noppes.npcs.controllers.data.Line; import noppes.npcs.controllers.data.Lines; import noppes.npcs.entity.EntityNPCInterface; @@ -49,6 +50,14 @@ public static void CheckNpcCompatibility(EntityNPCInterface npc, NBTTagCompound if (compound.hasKey("DialogDarkenScreen")) { compound.removeTag("DialogDarkenScreen"); } + + if (compound.hasKey("pEffect")) { + int effect = compound.getInteger("pEffect"); + EnumPotionType enumPotionType = EnumPotionType.fromOrdinal(effect); + if (enumPotionType == EnumPotionType.Fire) { + compound.setBoolean("pBurnItem", true); + } + } } if (npc.npcVersion < 12) { CompatabilityFix(compound, npc.advanced.writeToNBT(new NBTTagCompound())); From 948eb91b42c30be4b27d0e04268236a8a4f524a0 Mon Sep 17 00:00:00 2001 From: zeng-github01 <95841646+zeng-github01@users.noreply.github.com> Date: Sun, 29 Mar 2026 10:25:02 +0800 Subject: [PATCH 2/2] Fixes --- src/main/java/noppes/npcs/VersionCompatibility.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/noppes/npcs/VersionCompatibility.java b/src/main/java/noppes/npcs/VersionCompatibility.java index e468c0174..12562f15b 100644 --- a/src/main/java/noppes/npcs/VersionCompatibility.java +++ b/src/main/java/noppes/npcs/VersionCompatibility.java @@ -54,7 +54,7 @@ public static void CheckNpcCompatibility(EntityNPCInterface npc, NBTTagCompound if (compound.hasKey("pEffect")) { int effect = compound.getInteger("pEffect"); EnumPotionType enumPotionType = EnumPotionType.fromOrdinal(effect); - if (enumPotionType == EnumPotionType.Fire) { + if (!compound.hasKey("pBurnItem") && enumPotionType == EnumPotionType.Fire) { compound.setBoolean("pBurnItem", true); } }