Skip to content

Is this a bug in the GGX renderer? #24

@Jarvisss

Description

@Jarvisss

In the Cook-Torrance BRDF
f_specular = D * F * G / (4 * (n dot v) * (n dot l)),
In the co-located setting, you assume v==l,
so the equation should be
f_specular = D * F * G / (4 * (n dot v) ** 2), right?
but in your code implementation,

specular_rgb = light_intensity * specular_albedo * F * D * G / (4.0 * dot + 1e-10)

it is
f_specular = D * F * G / (4 * (n dot v),
not f_specular = D * F * G / (4 * (n dot v) ** 2)
Could you have a look at this? @Kai-46

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions