From 2e0907d8adfd2f5d071c4e9fe2af08c16138ce1c Mon Sep 17 00:00:00 2001 From: flan <505509679@qq.com> Date: Sat, 4 Nov 2023 12:44:37 +0800 Subject: [PATCH] Update renderer_ggx.py Fix GGX computation bug --- models/renderer_ggx.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/renderer_ggx.py b/models/renderer_ggx.py index 096a0cf..305944b 100644 --- a/models/renderer_ggx.py +++ b/models/renderer_ggx.py @@ -66,7 +66,7 @@ def forward(self, light, distance, normal, viewdir, diffuse_albedo, specular_alb ## compute shadowing term: https://github.com/mitsuba-renderer/mitsuba/blob/cfeb7766e7a1513492451f35dc65b86409655a7b/src/bsdfs/microfacet.h#L520 G = smithG1(dot, alpha) ** 2 # [..., 1] - specular_rgb = light_intensity * specular_albedo * F * D * G / (4.0 * dot + 1e-10) + specular_rgb = light_intensity * specular_albedo * F * D * G / (4.0 * cosTheta2 + 1e-10) # diffuse term: https://github.com/mitsuba-renderer/mitsuba/blob/cfeb7766e7a1513492451f35dc65b86409655a7b/src/bsdfs/roughplastic.cpp#L367 ## compute T12: : https://github.com/mitsuba-renderer/mitsuba/blob/cfeb7766e7a1513492451f35dc65b86409655a7b/src/bsdfs/rtrans.h#L183