regression from 5c4833e

[leggewie]

please revert commit 5c4833e which introduces a couple of regressions. in the future it would be nice if proper code inspection "git log -p" were to prevent commits that do not merge rebased code but simply overwrite other contributions.

ping @jeslynlamxy ping @Kalebu

[olichuuwon]

in addition to my response to this comment:
5c4833e#r128977068

i was unaware of the regressions as i could have been using an older version that worked instead, did not intent to "overwrite" your contributions, like i mentioned just trying to propose an additional function :)

[leggewie]

sure, but you should really inspect the code you are pushing. "git log -p" is your friend. please also make sure to learn how to use git branches and git merge and git rebase correctly. proper use of the git workflow (and proper inspection of code changes by the maintainer) would have prevented this.

@jeslynlamxy please go ahead and push a change that rebases your code on top of existing code instead of overwriting it. It is your responsibility to clean up after yourself.

And no, you weren't using an older version and thus unaware of changes upstream. 5c4833e is your commit, signed by you. It is sad you do not know how to inspect git history so you have to guess (incorrectly) in this regard.

[leggewie]

#127 discusses the issue you were trying to address. The issue is fixed but the ticket is still open. github can automatically close a ticket when a changeset is merged IF the proper commit message is used.

regressing on the following, previously fixed issues
#104
#105
#108
reverted 3611a0c
possibly others

[olichuuwon]

I express my appreciation for your feedback on the recent code changes. I understand your concerns regarding the regressions introduced by the recent commits.

I'd like to clarify that my intention was to propose an additional function to address an issue I encountered. I certainly didn't intend to introduce poor code or regressions intentionally, and if my changes have caused any issues, I genuinely apologize for any inconvenience they may have caused.

While I'm responsible for my contributions, the code manager or maintainer typically plays a significant role in reviewing, approving, and merging changes into the codebase.

Additionally, I kindly request that we maintain a respectful and constructive tone in our interactions. Harassment or hostile behaviour seen can be detrimental to the collaborative spirit of any project.

Please understand that I may not be able to respond promptly to further messages (away). I appreciate your understanding and patience.

Thanks lots. :)

[leggewie]

@olichuuwon Noted. Please direct your effort now to fixing the issue you created.