From bf2b1f3d470fd0496cdb8ab191cf7579b63b4df4 Mon Sep 17 00:00:00 2001 From: Vineet Bansal Date: Thu, 5 Feb 2026 09:58:43 -0500 Subject: [PATCH 1/3] prep for rc5 (#3) --- .github/workflows/release.yml | 14 ++++++++++---- CHANGELOG.md | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 73e9cc58..45bc18a4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,12 +20,17 @@ jobs: - id: tagcheck run: | - TAG=$(git tag --points-at HEAD) - if [[ "$TAG" =~ ^v?[0-9]+\.[0-9]+\.[0-9]+ ]]; then - echo "Detected tag: $TAG" - echo "tag=$TAG" >> $GITHUB_OUTPUT + # Get the merged commit (PR tip) + MERGED_COMMIT=$(git rev-parse HEAD^2 2>/dev/null || true) + + TAG="" + if [ -n "$MERGED_COMMIT" ]; then + TAG=$(git tag --points-at "$MERGED_COMMIT" | grep -E '^v?[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true) fi + echo "Detected tag: $TAG" + echo "tag=$TAG" >> $GITHUB_OUTPUT + build_sdist: name: Build source needs: detect_tag @@ -123,6 +128,7 @@ jobs: run: ls -la dist/* - name: Upload wheels to pypi + if: false env: TWINE_USERNAME: __token__ TWINE_PASSWORD: ${{ secrets.pypi_password }} diff --git a/CHANGELOG.md b/CHANGELOG.md index 3047668a..923a9db4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [1.4.0rc4] - 2026-02-04 +## [1.4.0rc5] - 2026-02-05 ### Added From 8efd27d7d1ef2df2e98f53dd8068ef47c176f0bf Mon Sep 17 00:00:00 2001 From: Vineet Bansal Date: Thu, 5 Feb 2026 10:13:48 -0500 Subject: [PATCH 2/3] prep for rc6 --- .github/workflows/release.yml | 54 ++++------------------------------- CHANGELOG.md | 2 +- 2 files changed, 7 insertions(+), 49 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 45bc18a4..f34539d1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,46 +1,20 @@ name: release on: - push: - branches: - - main + release: + types: [published] jobs: - detect_tag: - name: Detect Tag - runs-on: ubuntu-latest - outputs: - tag: ${{ steps.tagcheck.outputs.tag }} - - steps: - - uses: actions/checkout@v6 - with: - fetch-depth: 0 - - - id: tagcheck - run: | - # Get the merged commit (PR tip) - MERGED_COMMIT=$(git rev-parse HEAD^2 2>/dev/null || true) - - TAG="" - if [ -n "$MERGED_COMMIT" ]; then - TAG=$(git tag --points-at "$MERGED_COMMIT" | grep -E '^v?[0-9]+\.[0-9]+\.[0-9]+$' | head -n 1 || true) - fi - - echo "Detected tag: $TAG" - echo "tag=$TAG" >> $GITHUB_OUTPUT - build_sdist: name: Build source - needs: detect_tag - if: needs.detect_tag.outputs.tag != '' runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 with: fetch-depth: 0 + ref: ${{ github.event.release.tag_name }} - name: Build source run: | @@ -55,25 +29,9 @@ jobs: path: wheelhouse/*.tar.gz if-no-files-found: error - create_gh_release: - name: Create Github Release - needs: [detect_tag, build_sdist] - if: needs.detect_tag.outputs.tag != '' - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v6 - with: - fetch-depth: 0 - - uses: softprops/action-gh-release@v2 - with: - tag_name: ${{ needs.detect_tag.outputs.tag }} - generate_release_notes: true - build_wheels: name: Build wheel on ${{ matrix.os }} for ${{ matrix.cibw_archs }} - needs: [detect_tag, build_sdist] - if: needs.detect_tag.outputs.tag != '' + needs: [build_sdist] runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -95,6 +53,7 @@ jobs: - uses: actions/checkout@v6 with: fetch-depth: 0 + ref: ${{ github.event.release.tag_name }} - name: Build wheels uses: pypa/cibuildwheel@v3.3 @@ -113,8 +72,7 @@ jobs: publish_to_pypi: name: Publish wheels to PyPi - needs: [detect_tag, build_sdist, build_wheels] - if: needs.detect_tag.outputs.tag != '' + needs: [build_sdist, build_wheels] runs-on: ubuntu-latest steps: - name: Download packages diff --git a/CHANGELOG.md b/CHANGELOG.md index 923a9db4..a082f3a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [1.4.0rc5] - 2026-02-05 +## [1.4.0rc6] - 2026-02-05 ### Added From 69e7a90741d63a0cd29563818cec2151ca4a958f Mon Sep 17 00:00:00 2001 From: Vineet Bansal Date: Thu, 5 Feb 2026 10:27:23 -0500 Subject: [PATCH 3/3] re-enabled pypi step --- .github/workflows/release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f34539d1..1cf54b07 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -86,7 +86,6 @@ jobs: run: ls -la dist/* - name: Upload wheels to pypi - if: false env: TWINE_USERNAME: __token__ TWINE_PASSWORD: ${{ secrets.pypi_password }}