Skip to content

Commit bae7baf

Browse files
committed
revert linting
1 parent 2e8343f commit bae7baf

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

.github/workflows/blank.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ jobs:
4141
name: Lint
4242
if: ${{ matrix.target == 'web' }}
4343
run: yarn lint
44+
-
45+
name: Lint templates
46+
if: ${{ matrix.target == 'web' }}
47+
run: yarn lint:templates
4448
-
4549
name: Run tests
4650
if: ${{ matrix.target == 'web' }}

client/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"dev:cli": "tsc -w -p tsconfig.cli.json & tsc-alias -w -p tsconfig.cli.json",
1919
"divecli": "node ./bin/platform/desktop/backend/cli.js",
2020
"lint": "vue-cli-service lint src/ dive-common/ platform/",
21+
"lint:templates": "eslint --ext vue src/ dive-common/ platform/",
2122
"test": "vue-cli-service test:unit src/ dive-common/ platform/"
2223
},
2324
"resolutions": {
@@ -106,7 +107,7 @@
106107
"eslint": "^8.55.0",
107108
"eslint-import-resolver-typescript": "^2.2.0",
108109
"eslint-plugin-import": "^2.20.2",
109-
"eslint-plugin-vue": "^9.19.2",
110+
"eslint-plugin-vue": "^9.26.0",
110111
"express": "^4.17.1",
111112
"ffmpeg-ffprobe-static": "^4.4.0-rc.11",
112113
"fs-extra": "^9.0.1",

server/dive_utils/serializers/viame.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ def load_csv_as_tracks_and_attributes(
305305
) = _parse_row_for_tracks(row)
306306

307307
trackId, imageFile, _, _, _ = row_info(row)
308-
309308
if imageMap:
310309
# validate image ordering if the imageMap is provided
311310
imageName, _ = os.path.splitext(os.path.basename(imageFile))
@@ -334,6 +333,8 @@ def load_csv_as_tracks_and_attributes(
334333
(
335334
'Images were provided in an unexpected order '
336335
'and dataset contains multi-frame tracks. '
336+
f'featureFrame: {feature.frame} maxFeatureFrame: {maxFeatureFrame}'
337+
f'TrackId: {trackId}'
337338
)
338339
)
339340

@@ -359,15 +360,18 @@ def load_csv_as_tracks_and_attributes(
359360
continue
360361
k = index + 1
361362
if k < len(filteredImages):
363+
item_difference = foundImages[k]['csvFrame'] - item['csvFrame']
362364
if (
363-
item['csvFrame'] + 1 != filteredImages[k]['csvFrame']
364-
or item['frame'] + 1 != filteredImages[k]['frame']
365+
item['csvFrame'] + item_difference != filteredImages[k]['csvFrame']
366+
or item['frame'] + item_difference != filteredImages[k]['frame']
365367
):
366368
# We have misaligned video sequences so we error out
367369
raise ValueError(
368370
(
369371
'A subsampling of images were used with the CSV '
370372
'but they were not sequential'
373+
f'foundImage: {filteredImages[k]} item: {item}'
374+
f'item difference: {item_difference}'
371375
)
372376
)
373377
frameMapper[item['csvFrame']] = index
@@ -422,15 +426,20 @@ def load_csv_as_tracks_and_attributes(
422426
for index, item in enumerate(foundImages):
423427
k = index + 1
424428
if k < len(foundImages):
429+
# sometimes the frame difference isn't 1
430+
item_difference = foundImages[k]['csvFrame'] - item['csvFrame']
425431
if (
426-
item['csvFrame'] + 1 != foundImages[k]['csvFrame']
427-
or item['frame'] + 1 != foundImages[k]['frame']
432+
item['csvFrame'] + item_difference != foundImages[k]['csvFrame']
433+
or item['frame'] + item_difference != foundImages[k]['frame']
428434
):
429435
# We have misaligned video sequences so we error out
430436
raise ValueError(
431437
(
432438
'Images were provided in an unexpected order '
433439
'and dataset contains multi-frame tracks.'
440+
f'foundImage: {foundImages[k]} item: {item}'
441+
f'itemDifference: {item_difference}'
442+
434443
)
435444
)
436445

0 commit comments

Comments
 (0)