-
Notifications
You must be signed in to change notification settings - Fork 10
Description
Hello! I'm creating this issue as part of the review of your submission to JOSS at openjournals/joss-reviews#9066. This is a work-in-progress so I will keep adding comments. Please don't close this issue until the points have been addressed.
The authors present YACHT, a tool to accurately determine the presence/absence of genomes (from a reference database) in a metagenomic sample by incorporating average nucleotide identity (ANI) and sequencing coverage. It uses a k-mer based sketching technique, which avoids having to align samples to reference genomes makinf fast and efficient to process large datasets. The tool is well-implemented and I believe that after addressing the following comments, the paper can be accepted for publication in JOSS.
Major comments
- The title should be changed so it won't be confused with the original Bioinformatics publication.
- Could the authors please expand a bit more on the problems the software is designed to solve and who the target audience is in the documentation?
- The installation of YACHT is straightforward but the documentation should include a clearly-stated list of software dependencies.
- The manuscript mentions "FrachMinHash" which I believe should be "FracMinHash" introduced in sourmash. Also, it is better to cite the relevant paper for FracMinHash on line 79.
- Since the paper focuses more on the applications of YACHT, it would be helpful if the authors can expand on the workflow section and describe what inputs are needed for YACHT and what outputs are generated. I see that there is a section called "Output examples" on line 99, similarly you can add a section describing the inputs.
- Please add what data was used to generate the results in Table 1.
- Please add figure number and caption for the workflow diagram.
- Please refer the figure and table in the main text where relevant.
Minor comments
- The documentation link on anaconda directs to a different software. Please update it in the conda recipe.
- I noticed later that YACHT does not currently support MacOS after trying it out on an M4 Mac. However, the quick start code worked after I installed
wget(not installed by default on macOS). Also there are osx installers for YACHT on anaconda. Perhaps the documentation could be updated clearing these discrepancies. Just want to make sure that YACHT can be installed and works as intended on different OS architechtures.
Because of these points I cannot check all the boxes in the checklist. I'm happy to take a look once they have been addressed.