Skip to content

Not seeing improvements when using with request-promise #66

@rvillane

Description

@rvillane

Hi, I have multiple apps written in node 10, multiple apps talk to the same target apps, then I was hoping to gain a performance improvement by caching DNS lookup, however in my case, those lookups are not executed explicitly, instead uses request-promise NPM module and tried the example below making multiple calls to the same target URL, however when is executed without dns-lookup-cache, got comparable results.

Am I using the library incorrectly ?

const rp = require('request-promise');
const {lookup} = require('dns-lookup-cache');

function querySite() { 
    return new Promise((resolve, reject) => {
        rp({
            url: 'https://en.wikipedia.org/wiki/Costa_Rica',
            method: 'GET',
            lookup: lookup
        })
        .then(response => {
            resolve(response);
        })
        .catch(error => {
            reject(error);
        });              
    });            
}

const init = async () => {
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
    querySite().then(res => { console.log('Success'); }).catch(err => { console.log(`Error ${err}`); });
}
init();

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions