Skip to content

[Acts][AddAct]Unstable History ID Usage in AddActForm #24

@vibhatha

Description

@vibhatha

The selectedHistoryId state is currently set using the array index i. If the selectedAnalysis array is ever reordered, filtered, or modified, this could lead to incorrect history items being displayed when clicked.

It's more robust to use a stable unique identifier (e.g., hist.id) for setSelectedHistoryId to ensure that the correct item is always referenced, regardless of its position in the array.

Reference: web/components/acts/AddActForm.tsx lines 407-411.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions