-
Notifications
You must be signed in to change notification settings - Fork 3
[CC-007] Progress bar may swallow exceptions #19
Copy link
Copy link
Open
Labels
Description
Description
Progress bar context manager may swallow or obscure exceptions during collection.
Location
- File:
cost_collect.py- Progress display logic
Impact
- Exceptions may not be properly logged
- User may see incomplete progress without error details
Suggested Fix
Ensure exceptions are properly re-raised:
with Progress(...) as progress:
task = progress.add_task("Collecting costs", total=len(accounts))
for account in accounts:
try:
collect_account_costs(account)
except Exception as e:
logger.error(f"Failed for {account}: {e}")
raise # Don't swallow
finally:
progress.advance(task)Priority
Low
Source
cost_collect.py code review - CC-007
Reactions are currently unavailable