Skip to content

[CC-010] Magic numbers for Azure page size #23

@LFigg

Description

@LFigg

Description

Azure API page sizes use magic numbers without documentation.

Location

  • File: cost_collect.py - Azure cost collection

Impact

  • Unclear why specific page sizes were chosen
  • May not be optimal for performance

Suggested Fix

Move to constants with documentation:

# lib/constants.py

# Azure Cost Management API max page size
# Ref: https://docs.microsoft.com/en-us/rest/api/cost-management/
AZURE_COST_QUERY_PAGE_SIZE = 5000

Priority

Low

Source

cost_collect.py code review - CC-010

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions