-
Notifications
You must be signed in to change notification settings - Fork 3
[CC-010] Magic numbers for Azure page size #23
Copy link
Copy link
Open
Description
Description
Azure API page sizes use magic numbers without documentation.
Location
- File:
cost_collect.py- Azure cost collection
Impact
- Unclear why specific page sizes were chosen
- May not be optimal for performance
Suggested Fix
Move to constants with documentation:
# lib/constants.py
# Azure Cost Management API max page size
# Ref: https://docs.microsoft.com/en-us/rest/api/cost-management/
AZURE_COST_QUERY_PAGE_SIZE = 5000Priority
Low
Source
cost_collect.py code review - CC-010
Reactions are currently unavailable