Minor optimizations

Author: LTRData

Library/DiscUtils.Core/Internal/Utilities.cs

@@ -52,6 +52,9 @@ public static bool RangesOverlap<T>(T xFirst, T xLast, T yFirst, T yLast) where
 
     public static bool IsAllZeros(byte[] buffer, int offset, int count)
     {
+#if NET8_0_OR_GREATER
+        return !buffer.AsSpan(offset, count).ContainsAnyExcept((byte)0);
+#else
         var end = offset + count;
         for (var i = offset; i < end; ++i)
         {
@@ -62,10 +65,14 @@ public static bool IsAllZeros(byte[] buffer, int offset, int count)
         }
 
         return true;
+#endif
     }
 
     public static bool IsAllZeros(ReadOnlySpan<byte> buffer)
     {
+#if NET8_0_OR_GREATER
+        return !buffer.ContainsAnyExcept((byte)0);
+#else
         for (var i = 0; i < buffer.Length; ++i)
         {
             if (buffer[i] != 0)
@@ -75,6 +82,7 @@ public static bool IsAllZeros(ReadOnlySpan<byte> buffer)
         }
 
         return true;
+#endif
     }
 
     public static bool IsPowerOfTwo(uint val)
@@ -161,7 +169,7 @@ public static long BitSwap(long value)
         return (long)BitSwap((ulong)value);
     }
 
-    #endregion
+#endregion
 
     #region Path Manipulation
 
@@ -555,25 +563,25 @@ public static Func<string, bool> ConvertWildcardsToRegEx(string pattern, bool ig
             return null;
         }
 
-        if (pattern.AsSpan().IndexOfAny('*', '?') < 0)
+        static Func<string, bool> filterFactory((string pattern, bool ignoreCase) key)
         {
-            if (!pattern.Contains('.'))
-            {
-                pattern += '.';
-            }
-
-            if (ignoreCase)
+            if (key.pattern.AsSpan().IndexOfAny('*', '?') < 0)
             {
-                return name => StringComparer.OrdinalIgnoreCase.Equals(name, pattern);
+                if (!key.pattern.Contains('.'))
+                {
+                    key.pattern += '.';
+                }
+
+                if (key.ignoreCase)
+                {
+                    return name => StringComparer.OrdinalIgnoreCase.Equals(name, key.pattern);
+                }
+                else
+                {
+                    return key.pattern.Equals;
+                }
             }
-            else
-            {
-                return pattern.Equals;
-            }
-        }
 
-        static Func<string, bool> filterFactory((string pattern, bool ignoreCase) key)
-        {
             var regexOptions = RegexOptions.CultureInvariant | RegexOptions.Compiled;
 
             if (key.ignoreCase)
@@ -610,17 +618,10 @@ public static FileAttributes FileAttributesFromUnixFilePermissions(string name,
             attr |= FileAttributes.ReadOnly;
         }
 
-#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP
-        if (Path.GetFileName(name.AsSpan()).StartsWith(".", StringComparison.Ordinal))
+        if (GetFileFromPath(name.AsSpan()).StartsWith(".".AsSpan(), StringComparison.Ordinal))
         {
             attr |= FileAttributes.Hidden;
         }
-#else
-        if (Path.GetFileName(name).StartsWith(".", StringComparison.Ordinal))
-        {
-            attr |= FileAttributes.Hidden;
-        }
-#endif
 
         return attr;
     }