diff --git a/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java b/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java index d4bfc869c23..4fd3d7036ec 100644 --- a/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java +++ b/api/src/org/labkey/api/data/AbstractFileDisplayColumn.java @@ -266,7 +266,7 @@ public void renderInputHtml(RenderContext ctx, Writer out, Object value) throws Input.InputBuilder input = new Input.InputBuilder() .type("file") - .name(getInputPrefix() + formFieldName) + .name(formFieldName) .disabled(isDisabledInput(ctx)) .needsWrapping(false); @@ -288,7 +288,6 @@ public void renderInputHtml(RenderContext ctx, Writer out, Object value) throws /** * Enable subclasses to override the warning text * @param filename being displayed - * @return */ protected String getRemovalWarningText(String filename) { diff --git a/api/src/org/labkey/api/data/DataColumn.java b/api/src/org/labkey/api/data/DataColumn.java index 62287ca4df1..5f46fbc780c 100644 --- a/api/src/org/labkey/api/data/DataColumn.java +++ b/api/src/org/labkey/api/data/DataColumn.java @@ -103,9 +103,7 @@ public DataColumn(ColumnInfo col, boolean withLookups) { _width = _displayColumn.getWidth(); } - StringExpression url = withLookups ? - _boundColumn.getEffectiveURL() : - _boundColumn.getURL(); + StringExpression url = withLookups ? _boundColumn.getEffectiveURL() : _boundColumn.getURL(); if (null != url) super.setURLExpression(url); setLinkTarget(_boundColumn.getURLTargetWindow()); @@ -129,7 +127,6 @@ public DataColumn(ColumnInfo col, boolean withLookups) else _inputType = "select"; } - } catch (QueryParseException qpe) { @@ -143,7 +140,6 @@ public DataColumn(ColumnInfo col, boolean withLookups) _caption = StringExpressionFactory.create(_boundColumn.getLabel()); _editable = !_boundColumn.isReadOnly() && _boundColumn.isUserEditable(); _textAlign = _displayColumn.getTextAlign(); - } @@ -282,7 +278,7 @@ public void addQueryColumns(Set columns) @Override public boolean isSortable() { - return _sortFieldKeys != null && _sortFieldKeys.size() > 0; + return _sortFieldKeys != null && !_sortFieldKeys.isEmpty(); } @Override @@ -718,9 +714,9 @@ private void renderSelectFormInput( ) throws IOException { Select.SelectBuilder select = new Select.SelectBuilder() - .disabled(disabledInput) - .multiple("select.multiple".equalsIgnoreCase(_inputType)) - .name(getInputPrefix() + formFieldName); + .disabled(disabledInput) + .multiple("select.multiple".equalsIgnoreCase(_inputType)) + .name(formFieldName); List