From 429bd8a5407699b0cd0365fff5e9e00974fb11d1 Mon Sep 17 00:00:00 2001 From: cnathe Date: Fri, 15 Aug 2025 17:18:09 -0500 Subject: [PATCH] Issue 53620: Luminex import update to writeSameCheckboxCell to use "disabled" behavior instead of hiding the column inputs --- api/src/org/labkey/api/data/DisplayColumnGroup.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/api/src/org/labkey/api/data/DisplayColumnGroup.java b/api/src/org/labkey/api/data/DisplayColumnGroup.java index 5e8dc9d4331..8974afbd919 100644 --- a/api/src/org/labkey/api/data/DisplayColumnGroup.java +++ b/api/src/org/labkey/api/data/DisplayColumnGroup.java @@ -62,7 +62,7 @@ public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out) String id = getGroupFormFieldName(ctx) + "CheckBox"; InputBuilder.checkbox().name(id).id(id).appendTo(out); - StringBuilder onChange = new StringBuilder("b = this.checked;"); + StringBuilder onChange = new StringBuilder("b = this.checked;\n"); // Index starts at 1 -- always leave the first column visible for (int i = 1; i < _columns.size(); i++) @@ -71,15 +71,15 @@ public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out) ColumnInfo colInfo = col.getColumnInfo(); if (colInfo != null) { - onChange.append("document.getElementsByName('") - .append(col.getFormFieldName(ctx)) - .append("')[0].style.display = b ? 'none' : 'block';\n"); + // Issue 53620: instead of hiding the input, set it "disabled" via CSS (but not actually disabled so it will still submit) + onChange.append("document.getElementsByName('").append(col.getFormFieldName(ctx)).append("')[0].style.opacity = b ? 0.6 : 1;\n"); + onChange.append("document.getElementsByName('").append(col.getFormFieldName(ctx)).append("')[0].style.pointerEvents = b ? 'none' : 'all';\n"); } } onChange.append(" if (b) { ") .append(getGroupFormFieldName(ctx)) - .append("Updated(); }"); + .append("Updated(); }\n"); HttpView.currentPageConfig().addHandler(id, "change", onChange.toString());