Fix metadata uploads with local file datarow upload

Author: Kevin Kim

labelbox/schema/dataset.py

@@ -260,11 +260,10 @@ def upload_if_necessary(item):
             row_data = item['row_data']
             if os.path.exists(row_data):
                 item_url = self.client.upload_file(item['row_data'])
-                item = {
-                    "row_data": item_url,
-                    "external_id": item.get('external_id', item['row_data']),
-                    "attachments": item.get('attachments', [])
-                }
+                item['row_data'] = item_url
+                if 'external_id' not in item:
+                    # Default `external_id` to local file name
+                    item['external_id'] = row_data
             return item
 
         def validate_attachments(item):

tests/integration/conftest.py

@@ -188,6 +188,12 @@ def iframe_url(environ) -> str:
         return 'https://editor.lb-stage.xyz'
 
 
+@pytest.fixture
+def sample_image() -> str:
+    path_to_video = 'tests/integration/media/sample_image.jpg'
+    return path_to_video
+
+
 @pytest.fixture
 def sample_video() -> str:
     path_to_video = 'tests/integration/media/cat.mp4'

tests/integration/media/sample_image.jpg

@@ -570,3 +570,15 @@ def test_create_data_rows_result(client, dataset, image_url):
     assert task.errors is None
     for result in task.result:
         client.get_data_row(result['id'])
+
+
+def test_create_data_rows_local_file(dataset, sample_image):
+    task = dataset.create_data_rows([{
+        DataRow.row_data: sample_image,
+        DataRow.metadata_fields: make_metadata_fields()
+    }])
+    task.wait_till_done()
+    assert task.status == "COMPLETE"
+    data_row = list(dataset.data_rows())[0]
+    assert data_row.external_id == "tests/integration/media/sample_image.jpg"
+    assert len(data_row.metadata_fields) == 4