Possible .dockerignore misconfiguration #2017
tomokinakamaru
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
(I am posting this here because I was not sure if it is actually a bug or not.)
As part of my research, I am analyzing how developers configure .dockerignore in popular repositories.
During my analysis, I noticed that
/.dockerignore
might have been written under the assumption that .dockerignore and .gitignore follow the same pattern semantics, while they actually differ.1 In particular, the following pattern drew my attention:labelbox-python/.dockerignore
Line 1 in a508d19
According to Docker's specification, this pattern matches
__pycache__
only in the top-level directory. (To ignore__pycache__
in any directory, the .dockerignore file needs to list**/__pycache__
)Was this pattern written intentionally? If not, I'd be happy to submit a pull request to adjust it.
And if possible, could one of the maintainers tell me whether they were aware of the difference between .dockerignore and .gitignore? (I would like to know whether the differences are generally well recognized, or if they tend to slip developers' minds.)
Thank you again for maintaining this repository!
Footnotes
See .gitignore doc, .dockerignore doc, and a blog post about the differences ↩
Beta Was this translation helpful? Give feedback.
All reactions