From 337a205288a4c7d5d48d665b47b15399850abb4d Mon Sep 17 00:00:00 2001 From: elenagarrone <8397116+elenagarrone@users.noreply.github.com> Date: Thu, 11 Dec 2025 09:05:07 +0000 Subject: [PATCH 1/3] refactor: update leftovers ngIf and ngFor in specs and stories --- .../lib/accordion/docs/accordion.stories.ts | 21 ++++++- .../src/lib/card/docs/card/card.stories.ts | 49 ++++++++------- .../docs/promotions/promotions.stories.ts | 4 +- .../src/lib/footer/docs/footer.stories.ts | 51 +++++++++------- .../checkbox-group.component.spec.ts | 2 - .../src/lib/forms/input/docs/input.stories.ts | 60 +++++++++++-------- .../forms/input/input-field.component.spec.ts | 5 +- .../forms/radio/docs/radio/radio.stories.ts | 4 +- .../radio/docs/segment/segment.stories.ts | 4 +- .../lib/forms/select/docs/select.stories.ts | 8 ++- .../forms/sort-code/docs/sort-code.stories.ts | 4 +- .../docs/checkbox/checkbox-group.stories.ts | 4 +- .../lib/forms/toggle/docs/checkbox/guide.mdx | 4 +- .../src/lib/forms/validation/docs/guide.mdx | 16 +++-- .../lib/link-menu/docs/link-menu.stories.ts | 27 +++++---- .../canopy/src/lib/list/docs/lists.stories.ts | 32 +++++----- .../canopy/src/lib/page/docs/page.stories.ts | 19 +++--- .../lib/promo-card/docs/promo-card.stories.ts | 41 ++++++------- .../src/lib/side-nav/docs/side-nav.stories.ts | 36 +++++------ .../lib/spacing/margin/docs/margin.stories.ts | 26 ++++---- .../spacing/padding/docs/padding.stories.ts | 23 ++++--- .../src/lib/spinner/docs/spinner.stories.ts | 4 +- .../src/lib/sr-alert-message/docs/guide.mdx | 4 +- .../src/lib/table/docs/table.stories.ts | 40 +++++++------ .../lib/table/table/table.component.spec.ts | 16 ++--- .../src/lib/tabs/docs/tab-nav-bar.stories.ts | 12 ++-- .../canopy/src/lib/tabs/docs/tabs.stories.ts | 14 +++-- 27 files changed, 303 insertions(+), 227 deletions(-) diff --git a/projects/canopy/src/lib/accordion/docs/accordion.stories.ts b/projects/canopy/src/lib/accordion/docs/accordion.stories.ts index 234993787..224fddf89 100644 --- a/projects/canopy/src/lib/accordion/docs/accordion.stories.ts +++ b/projects/canopy/src/lib/accordion/docs/accordion.stories.ts @@ -14,7 +14,12 @@ const accordionItems = ` - Item 1 + + @if (iconForFirstAccordionItem) { + + } + Item 1 +

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.

@@ -22,7 +27,12 @@ const accordionItems = ` - Item 2 + + @if (iconForSecondAccordionItem) { + + } + Item 2 +

Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in @@ -33,7 +43,12 @@ const accordionItems = ` - Item 3 is Lazy + + @if (iconForThirdAccordionItem) { + + } + Item 3 is Lazy +

This panel content is only initialised when opened

diff --git a/projects/canopy/src/lib/card/docs/card/card.stories.ts b/projects/canopy/src/lib/card/docs/card/card.stories.ts index 23ce34af7..f3e064ac7 100644 --- a/projects/canopy/src/lib/card/docs/card/card.stories.ts +++ b/projects/canopy/src/lib/card/docs/card/card.stories.ts @@ -71,7 +71,9 @@ const formJourneyTemplate = ` {{label}} - {{hint}} + @if (hint) { + {{hint}} + } @@ -177,12 +179,12 @@ const showMoreCardTemplate = `
@@ -257,14 +259,16 @@ const dataPointsCardTemplate = ` - - - {{data[i].label}} - - - {{data[i].value}} - - + @for (number of [].constructor(dataPoints); track $index; let i = $index) { + + + {{data[i].label}} + + + {{data[i].value}} + + + } @@ -328,15 +332,16 @@ const cardGroupTemplate = ` explicabo. - - - - - - {{ cardContent }} Test link. - - + @for (i of [].constructor(additionalCards); track $index) { + + + + + + {{ cardContent }} Test link. + + diff --git a/projects/canopy/src/lib/card/docs/promotions/promotions.stories.ts b/projects/canopy/src/lib/card/docs/promotions/promotions.stories.ts index 35b303968..367c96046 100644 --- a/projects/canopy/src/lib/card/docs/promotions/promotions.stories.ts +++ b/projects/canopy/src/lib/card/docs/promotions/promotions.stories.ts @@ -26,7 +26,9 @@ const promotionsGeneralCardTemplate = ` - + @if (hasIcon) { + + }

{{ title }}

diff --git a/projects/canopy/src/lib/footer/docs/footer.stories.ts b/projects/canopy/src/lib/footer/docs/footer.stories.ts index f279057af..057af9ee1 100644 --- a/projects/canopy/src/lib/footer/docs/footer.stories.ts +++ b/projects/canopy/src/lib/footer/docs/footer.stories.ts @@ -1,5 +1,4 @@ import { Meta, moduleMetadata } from '@storybook/angular'; -import { NgFor, NgIf } from '@angular/common'; import { LgFooterComponent } from '../footer.component'; import { LgFooterNavComponent } from '../footer-nav/footer-nav.component'; @@ -51,8 +50,6 @@ export default { LgFooterNavItemComponent, LgFooterLogoComponent, LgFooterCopyrightComponent, - NgIf, - NgFor, ], }), ], @@ -96,19 +93,23 @@ export default { const template = `