tests: improve test coverage for access/nat rules recovery

Author: LetMeR00t

tests/management/access_control_nat/test_access_rule.py

@@ -197,7 +197,7 @@ def test_show_access_rulebase(management, resp_access_rulebase):
     resp = management.access_control_nat.access_rule.show_access_rulebase(
         name="Network",
         offset=0,
-        limit=20,
+        limit=2,
         order={"ASC": "name"},
         package="",
         details_level="standard",
@@ -221,6 +221,12 @@ def test_show_access_rulebase(management, resp_access_rulebase):
 
     assert isinstance(resp.total, int)
 
+    resp = management.access_control_nat.access_rule.show_access_rulebase(
+        uid="21127e7c-d19b-4c65-b9c3-8e20e66ea1ae", show_all=True, limit=2
+    )
+
+    assert resp.total == 3
+
     # Missing mandatory parameter
     with pytest.raises(MandatoryFieldMissing):
         management.access_control_nat.access_rule.show_access_rulebase()

tests/management/access_control_nat/test_nat_rule.py

@@ -174,12 +174,30 @@ def test_show_nat_rulebase(management, resp_nat_rulebase):
     resp = management.access_control_nat.nat_rule.show_nat_rulebase(
         package="standard",
         offset=0,
-        limit=20,
+        limit=2,
         order={"ASC": "name"},
         details_level="standard",
         use_object_dictionnary=True,
         filter_results="",
         filter_settings={},
+        show_hits=True,
+        hits_settings={
+            "from-date": "2014-01-01",
+            "to-date": "2014-12-31T23:59",
+            "target": "corporate-gw",
+        },
     )
 
     assert isinstance(resp.total, int)
+
+    resp = management.access_control_nat.nat_rule.show_nat_rulebase(package="standard")
+
+    assert isinstance(resp.total, int)
+
+    resp = management.access_control_nat.nat_rule.show_nat_rulebase(
+        package="standard", show_all=True, limit=2
+    )
+
+    assert resp.total == 4
+
+    assert isinstance(resp.total, int)