Skip to content

🚨Bug-Report: Auto-merge silently requires contributors/ file change - undocumented, causes level 2/3/4 PRs to stall indefinitely #389

@kshubham090

Description

@kshubham090

Hey @LifeAtlas 👋
Found a non-obvious bug in validate-contributor.yml that caused my PR to sit open while others merged instantly.

The problem:

Auto-merge for level 2/3/4 PRs only triggers when three conditions are all true:
level != '1' AND has_contributor == 'true' AND validate_contributor.outputs.valid == 'true'

The has_contributor flag is only set to true when the PR includes a change to contributors/*.json. This is nowhere documented — not in the README, not in CONTRIBUTING.md, and the workflow posts no
comment when it silently skips auto-merge.

What happens in practice:

A contributor submitting a clean level 3/4 PR (submission files only, no contributor JSON touch) gets:

  • Automated score comment ✅
  • No merge ❌
  • No explanation why ❌

They wait indefinitely while contributors who happen to bundle a contributors/ update get auto-merged immediately. Issue #2 in this repo is the same root cause.

Fix options:

  1. Add a workflow comment when has_contributor == false explaining what's missing
  2. Or document in the README that every PR must include a contributors/ update
  3. Or remove the requirement and auto-merge on valid submission alone

I ran into this on PR #388. Happy to raise a PR for whichever fix you prefer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions