Skip to content

LKE-13676 fix(thumbnails): have coherent thumbnails #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+17 −0
Open

LKE-13676 fix(thumbnails): have coherent thumbnails #899

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b83782
LKE-13676 fix(thumbnails): have coherent thumbnails
Nov 25, 2025
07b1c02
Merge branch 'develop' into LKE-13676-fix-thumbnails-coherence
WilliamGorge Nov 26, 2025
8d3d4d2
LKE-13676 fix: limit thumbnail size
Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/api/Visualization/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,20 @@ export interface IVisualizationTimeline {
zoomLevel?: ZoomLevel;
}

export interface VisualizationThumbnailData {
svg: string; // Should not exceed a certain size, cf isThumbnailTooLarge
}

export const MAX_VISUALIZATION_THUMBNAIL_SIZE_BYTES = 2_097_152; // 2MB

export function isThumbnailTooLarge(
thumbnail: VisualizationThumbnailData | null | undefined
): boolean {
const thumbnailContent = thumbnail?.svg ?? '';
const thumbnailSizeBytes = new TextEncoder().encode(thumbnailContent).byteLength;
return thumbnailSizeBytes > MAX_VISUALIZATION_THUMBNAIL_SIZE_BYTES;
}

export interface BaseVisualization {
nodes: IVizNodeInfo[];
nodeGroups?: IVizNodeGroupInfo[];
Expand Down Expand Up @@ -218,6 +232,7 @@ export interface ICreateVisualizationParams extends IDataSourceParams {
timeline?: IVisualizationTimeline;
layout?: VisualizationLayout;
geo?: IVisualizationGeo;
thumbnail?: VisualizationThumbnailData | null; // Set explicitly to null to remove an existing thumbnail
}

export interface IDuplicateVisualizationParams extends IDataSourceParams {
Expand Down Expand Up @@ -254,6 +269,7 @@ export interface SharedVisualization {
locked: boolean;
lastLockedByUser: Pick<User, 'username' | 'email'>;
lastEditedByUser: Pick<User, 'username' | 'email'>;
thumbnail?: VisualizationThumbnailData;
}

export type GetSharedVisualizationsResponse = SharedVisualization[];
Expand Down Expand Up @@ -291,6 +307,7 @@ export interface VisualizationTreeItem {
lastLockedByUser: Pick<User, 'username' | 'email'>;
lastEditedByUser: Pick<User, 'username' | 'email'>;
locked: boolean;
thumbnail?: VisualizationThumbnailData;
}

export type VisualizationTree = Tree<VisualizationTreeItem, 'visu'>;
Expand Down