fix: forbid returning null from tree walker

Lodin · Lodin · commit 217a140592bf · 2019-08-12T01:23:58.000+03:00
diff --git a/__stories__/FixedSizeTree.story.tsx b/__stories__/FixedSizeTree.story.tsx
@@ -52,7 +52,7 @@ const defaultButtonStyle = {fontFamily: 'Courier New'};
 
 function* treeWalker(
   refresh: boolean,
-): IterableIterator<CommonNodeMetadata | string | symbol | null> {
+): IterableIterator<CommonNodeMetadata | string | symbol> {
   const stack: StackElement[] = [];
 
   stack.push({
diff --git a/__stories__/VariableSizeTree.story.tsx b/__stories__/VariableSizeTree.story.tsx
@@ -109,7 +109,7 @@ const TreePresenter: React.FunctionComponent<TreePresenterProps> = ({
   const treeWalker = React.useCallback(
     function*(
       refresh: boolean,
-    ): IterableIterator<VariableSizeNodeMetadata | string | symbol | null> {
+    ): IterableIterator<VariableSizeNodeMetadata | string | symbol> {
       const stack: StackElement[] = [];
 
       stack.push({
diff --git a/__tests__/FixedSizeTree.spec.tsx b/__tests__/FixedSizeTree.spec.tsx
@@ -43,7 +43,7 @@ describe('FixedSizeTree', () => {
 
     treeWalkerSpy = jest.fn(function*(
       refresh: boolean,
-    ): IterableIterator<FixedSizeNodeMetadata | string | symbol | null> {
+    ): IterableIterator<FixedSizeNodeMetadata | string | symbol> {
       const stack: StackElement[] = [];
 
       stack.push({
diff --git a/__tests__/VariableSizeTree.spec.tsx b/__tests__/VariableSizeTree.spec.tsx
@@ -46,7 +46,7 @@ describe('VariableSizeTree', () => {
 
     treeWalkerSpy = jest.fn(function*(
       refresh: boolean,
-    ): IterableIterator<VariableSizeNodeMetadata | string | symbol | null> {
+    ): IterableIterator<VariableSizeNodeMetadata | string | symbol> {
       const stack: StackElement[] = [];
 
       stack.push({
diff --git a/src/utils.tsx b/src/utils.tsx
@@ -61,7 +61,7 @@ export interface TreeProps<TMetadata extends CommonNodeMetadata> {
   readonly rowComponent?: React.ComponentType<ListChildComponentProps>;
   readonly treeWalker: (
     refresh: boolean,
-  ) => IterableIterator<TMetadata | string | symbol | null>;
+  ) => IterableIterator<TMetadata | string | symbol>;
 }
 
 export interface TreeState<T extends CommonNodeRecord> {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export interface TreeProps<TMetadata extends CommonNodeMetadata> {`
`61`	`61`	`readonly rowComponent?: React.ComponentType<ListChildComponentProps>;`
`62`	`62`	`readonly treeWalker: (`
`63`	`63`	`refresh: boolean,`
`64`		`- ) => IterableIterator<TMetadata \| string \| symbol \| null>;`
	`64`	`+ ) => IterableIterator<TMetadata \| string \| symbol>;`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`export interface TreeState<T extends CommonNodeRecord> {`