Skip to content

Commit 447fb17

Browse files
committed
fix: clarify naming for individual isosurfaces based on input name, don't add isovalue when not needed
1 parent bc4ca17 commit 447fb17

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

LoopStructural/utils/_surface.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,18 @@ def fit(
115115
values,
116116
)
117117
logger.info(f'Isosurfacing at values: {isovalues}')
118+
individual_names = False
118119
if name is None:
119120
names = ["surface"] * len(isovalues)
120121
if isinstance(name, str):
121122
names = [name] * len(isovalues)
123+
if len(isovalues) == 1:
124+
individual_names = True
122125
if isinstance(name, list):
123126
names = name
127+
print(len(names), len(isovalues))
128+
if len(names) == len(isovalues):
129+
individual_names = True
124130
if colours is None:
125131
colours = [None] * len(isovalues)
126132
for name, isovalue, colour in zip(names, isovalues, colours):
@@ -146,12 +152,13 @@ def fit(
146152
# need to add both global and local origin. If the bb is a buffer the local
147153
# origin may not be 0
148154
verts += self.bounding_box.global_origin+self.bounding_box.origin
155+
print(name, individual_names)
149156
surfaces.append(
150157
Surface(
151158
vertices=verts,
152159
triangles=faces,
153160
normals=normals,
154-
name=f"{name}_{isovalue}",
161+
name=name if individual_names else f"{name}_{isovalue}",
155162
values=values,
156163
colour=colour,
157164
)

0 commit comments

Comments
 (0)