fix: 🐛 weight for p2 interpolator wasn't being applied

Author: Lachlan Grose

LoopStructural/interpolators/_p2interpolator.py

@@ -169,9 +169,10 @@ def add_value_constraints(self, w=1.0):
             wt = np.ones(size.shape[0])
             wt *= w
             self.add_constraints_to_least_squares(
-                N[mask, :] * wt[:, None],
-                points[mask, 3] * wt,
+                N[mask, :],
+                points[mask, 3],
                 self.support.elements[elements[mask], :],
+                w=wt,
                 name="value",
             )
 
@@ -199,17 +200,17 @@ def minimise_grad_steepness(self, w=0.1, maskall=True, wtfunc=None):
         d2 = self.support.evaluate_shape_d2(elements[mask])
         # d2 is [ele_idx, deriv, node]
         wt = np.ones(d2.shape[0])
-
         wt *= w  # * self.support.element_size[mask]
         if callable(wtfunc):
             logger.info("Using function to weight gradient steepness")
             wt = wtfunc(self.support.barycentre) * self.support.element_size[mask]
         idc = self.support.elements[elements[mask]]
         for i in range(d2.shape[1]):
             self.add_constraints_to_least_squares(
-                d2[:, i, :] * wt[i, None, None],
+                d2[:, i, :],
                 np.zeros(d2.shape[0]),
                 idc[:, :],
+                w=wt,
                 name=f"grad_steepness_{i}",
             )
 
@@ -247,9 +248,10 @@ def minimise_edge_jumps(
             if wtfunc:
                 wt = wtfunc(tri_cp)
             self.add_constraints_to_least_squares(
-                const_cp * wt[:, None],
+                const_cp,
                 np.zeros(const_cp.shape[0]),
                 tri_cp,
+                w=wt,
                 name=f"shared element jump cp{i}",
             )