fix: recursive error fix

Author: Lachlan Grose

LoopStructural/modelling/features/_geological_feature.py

@@ -61,7 +61,6 @@ def __init__(
         self.builder = builder
         self.type = FeatureType.INTERPOLATED
 
-         
     def is_valid(self):
         return self.interpolator.valid
 
@@ -103,10 +102,10 @@ def evaluate_value(self, evaluation_points):
         mask[:] = True
         # check regions
         for r in self.regions:
-            try:
-                mask = np.logical_and(mask, r(evaluation_points))
-            except:
-                logger.error("nan slicing")
+            # try:
+            mask = np.logical_and(mask, r(evaluation_points))
+            # except:
+            #     logger.error("nan slicing")
         # apply faulting after working out which regions are visible
         if self.faults_enabled:
             for f in self.faults:

LoopStructural/modelling/features/_unconformity_feature.py

@@ -5,7 +5,7 @@
 class UnconformityFeature(GeologicalFeature):
     """ """
 
-    def __init__(self, feature: GeologicalFeature, value: float):
+    def __init__(self, feature: GeologicalFeature, value: float, sign=True):
         """
 
         Parameters
@@ -26,6 +26,7 @@ def __init__(self, feature: GeologicalFeature, value: float):
         )
         self.value = value
         self.type = FeatureType.UNCONFORMITY
+        self.sign = sign
 
     def evaluate(self, pos):
         """
@@ -40,4 +41,7 @@ def evaluate(self, pos):
         boolean
             true if above the unconformity, false if below
         """
-        return self.evaluate_value(pos) < self.value
+        if self.sign:
+            return self.evaluate_value(pos) < self.value
+        if not self.sign:
+            return self.evaluate_value(pos) > self.value