Skip to content

Noelle/contact extractor #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Noelle/contact extractor #232

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bad6a7
fix extract_basal_contacts
noellehmcheng Aug 27, 2025
8db462a
remove symb link
noellehmcheng Aug 27, 2025
73a2341
change comment in extract_basal_contacts
noellehmcheng Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions map2loop/contact_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,19 +62,18 @@ def extract_basal_contacts(self,
basal_contacts = self.contacts.copy()
else:
basal_contacts = self.contacts.copy()
if any(unit not in units for unit in basal_contacts["UNITNAME_1"].unique()):
missing_units = (
basal_contacts[~basal_contacts["UNITNAME_1"].isin(units)]["UNITNAME_1"]
.unique()
.tolist()
)
units_1 = set(basal_contacts["UNITNAME_1"])
units_2 = set(basal_contacts["UNITNAME_2"])
all_contact_units = units_1.union(units_2)
missing_units = [unit for unit in all_contact_units if unit not in units]
if missing_units:
logger.error(
"There are units in the Geology dataset, but not in the stratigraphic column: "
+ ", ".join(missing_units)
+ ". Please readjust the stratigraphic column if this is a user defined column."
)
raise ValueError(
"There are units in stratigraphic column, but not in the Geology dataset: "
"There are units in the Geology dataset, but not in the stratigraphic column: "
+ ", ".join(missing_units)
+ ". Please readjust the stratigraphic column if this is a user defined column."
)
Expand Down
Loading