Skip to content

Commit 6144a00

Browse files
authored
Track cgm device when uploading BG data (#1222)
* Track cgm device when uploading BG data * Bump carthage revs
1 parent caf87ed commit 6144a00

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

Cartfile.resolved

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ github "LoopKit/CGMBLEKit" "96de871ed517630cfc2c9c68ac9698870086d6c9"
33
github "LoopKit/G4ShareSpy" "e5268fd8d458ddbd722187217a638d99a4578bc3"
44
github "LoopKit/LoopKit" "3ea3bb600b599701f4fe0196409b1249c3d4e8bc"
55
github "LoopKit/MKRingProgressView" "f548a5c64832be2d37d7c91b5800e284887a2a0a"
6-
github "LoopKit/dexcom-share-client-swift" "fe47b7a8f1f0e809ab4525520c559ab0e07a9d1c"
6+
github "LoopKit/dexcom-share-client-swift" "83b89d5badb86219a5da400437fc3cdea12b03b3"
77
github "i-schuetz/SwiftCharts" "0.6.5"
8-
github "ps2/rileylink_ios" "2888970adca367922b436d5245e26b0738700c07"
8+
github "ps2/rileylink_ios" "0dc526607ce2b06f48dadf58a3fd7b39fe11e452"

Loop/Managers/DeviceDataManager.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,12 @@ final class DeviceDataManager {
160160
switch result {
161161
case .newData(let values):
162162
log.default("CGMManager:\(type(of: manager)) did update with \(values.count) values")
163-
163+
164164
loopManager.addGlucose(values) { result in
165165
if manager.shouldSyncToRemoteService {
166166
switch result {
167167
case .success(let values):
168-
self.nightscoutDataManager.uploadGlucose(values, sensorState: manager.sensorState)
168+
self.nightscoutDataManager.uploadGlucose(values, sensorState: manager.sensorState, fromDevice: manager.device)
169169
case .failure:
170170
break
171171
}

Loop/Managers/NightscoutDataManager.swift

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -406,12 +406,17 @@ final class NightscoutDataManager {
406406
uploader.uploadDeviceStatus(deviceStatus)
407407
}
408408

409-
func uploadGlucose(_ values: [GlucoseValue], sensorState: SensorDisplayable?) {
409+
func uploadGlucose(_ values: [GlucoseValue], sensorState: SensorDisplayable?, fromDevice device: HKDevice?) {
410410
guard let uploader = deviceManager.remoteDataManager.nightscoutService.uploader else {
411411
return
412412
}
413-
414-
let device = "loop://\(UIDevice.current.name)"
413+
414+
var deviceStr: String
415+
if let device = device {
416+
deviceStr = [device.name, device.manufacturer, device.model, device.firmwareVersion, device.softwareVersion].compactMap { $0 }.joined(separator: " ")
417+
} else {
418+
deviceStr = "loop://unknowndevice"
419+
}
415420
let direction: String? = {
416421
switch sensorState?.trendType {
417422
case .up?:
@@ -434,9 +439,10 @@ final class NightscoutDataManager {
434439
glucoseMGDL: Int(value.quantity.doubleValue(for: .milligramsPerDeciliter)),
435440
at: value.startDate,
436441
direction: direction,
437-
device: device
442+
device: deviceStr
438443
)
439444
}
445+
uploader.flushAll();
440446
}
441447
}
442448

0 commit comments

Comments
 (0)