From b7cd3eee5e6217473ab2657909bfe93e8cf521d2 Mon Sep 17 00:00:00 2001 From: Zhangzhang Li Date: Tue, 13 Apr 2021 09:43:00 -0700 Subject: [PATCH] code review from zhangzhang li --- code_review_zhangzhang | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 code_review_zhangzhang diff --git a/code_review_zhangzhang b/code_review_zhangzhang new file mode 100644 index 0000000..9d6283e --- /dev/null +++ b/code_review_zhangzhang @@ -0,0 +1,16 @@ +UX Feedbacks: + +1. Great Styles and the webpage is very easy to use! +2. The "Tada" Dialog is cute. However, it is a little distractive for user. +3. While filtering by a tag, there is no way to remove the filter except clicking the Home link. (this could be a future feature) +4. The search item input requires enter to take effect. It will be better if it can do search with the input. +5. the layout of Edit/Delete buttons in the "My Articles" may need some improve. +6. Maybe have a logo to replace the "Your Company Logo" in the login page. + +Code feedback: + +1. nice code organization! +2. remove unused files like App.css. +3. should have propTypes for all the components +4. in NewArticle.js, used then() in some async functions. async/await should be better +5. in myDB.js, "tagFilter === '' || tagFilter === undefined" could be simplied as "!tagFilter"