Skip to content

Water mass is not removed from environment at initialisation #87

@Calebsakhtar

Description

@Calebsakhtar

When calculating the ice mass uptake from the environment in

const double icemass = iceAerosol_.TotalIceMass_sum(areas);
double mass_WV = WV_exhaust_ - icemass;
double E_H2O = mass_WV / (MW_H2O * 1e3) * Na;

WV_exhaust_ is in g but it is combined with icemass which is in kg and then divided by 1e3 (which assumes grams).

This leads to WV_exhaust_ being effectively 1e3 higher than the icemass, guaranteeing that water is added to (not subtracted from) the environment.

Effectively, the bugfix from PR #59 , which attempted to solve the issue of water being double-counted (see Issue #39) resulted in tiny changes to the contrail properties because the bugged equations reduce to the ones prior to the bugfix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions