From 41c0d9fc9d25d2fa89b5498c715cb4c03be626c6 Mon Sep 17 00:00:00 2001 From: rosaboyle <107982023+rosaboyle@users.noreply.github.com> Date: Sun, 16 Apr 2023 17:21:35 -0400 Subject: [PATCH 1/2] Fix bug in diag Diagonal still has bug --- TicTacToe/ticTacToe.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/TicTacToe/ticTacToe.py b/TicTacToe/ticTacToe.py index 5e18039..c6754af 100644 --- a/TicTacToe/ticTacToe.py +++ b/TicTacToe/ticTacToe.py @@ -40,13 +40,13 @@ def winner(self): # diagonal diag_sum1 = sum([self.board[i, i] for i in range(BOARD_COLS)]) diag_sum2 = sum([self.board[i, BOARD_COLS - i - 1] for i in range(BOARD_COLS)]) - diag_sum = max(abs(diag_sum1), abs(diag_sum2)) - if diag_sum == 3: + # diag_sum = max(diag_sum1, diag_sum2) + if diag_sum1 == 3 or diag_sum2 == 3: self.isEnd = True - if diag_sum1 == 3 or diag_sum2 == 3: - return 1 - else: - return -1 + return 1 + if diag_sum1 == -3 or diag_sum2 == -3: + self.isEnd = True + return -1 # tie # no available positions From b875b7516916a45e5e5bdc27551433eaaa6f4f9c Mon Sep 17 00:00:00 2001 From: rosaboyle <107982023+rosaboyle@users.noreply.github.com> Date: Sun, 16 Apr 2023 17:23:09 -0400 Subject: [PATCH 2/2] Update tic-tac-toe.ipynb --- TicTacToe/tic-tac-toe.ipynb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/TicTacToe/tic-tac-toe.ipynb b/TicTacToe/tic-tac-toe.ipynb index f2a6277..9ef8853 100644 --- a/TicTacToe/tic-tac-toe.ipynb +++ b/TicTacToe/tic-tac-toe.ipynb @@ -83,11 +83,11 @@ " # diagonal\n", " diag_sum1 = sum([self.board[i, i] for i in range(BOARD_COLS)])\n", " diag_sum2 = sum([self.board[i, BOARD_COLS-i-1] for i in range(BOARD_COLS)])\n", - " diag_sum = max(diag_sum1, diag_sum2)\n", - " if diag_sum == 3:\n", + " #diag_sum = max(diag_sum1, diag_sum2)\n", + " if diag_sum1 == 3 or diag_sum2 == 3 :\n", " self.isEnd = True\n", " return 1\n", - " if diag_sum == -3:\n", + " if diag_sum1 == -3 or diag_sum2 == -3:\n", " self.isEnd = True\n", " return -1\n", " \n",