image upload adjustments

[pkyeck]

would be great if API also supported upload via application/octet-stream.
see example here: https://github.com/valums/file-uploader/blob/master/server/nodejs.js

and could you add a success: true if upload succeeded?
that way I could use the https://github.com/valums/file-uploader/ to implement uploading multiple images.

what do you think?

[aronwoost]

Is octet-stream currently actively declined? Not sure about it. However, since application/octet-stream can be any binary I'm not sure, if it should be allowed.

Is there a documentation when the success should be fired? Is it standart? I just want to be sure that it does not collide with the "regular" return value...

[pkyeck]

don't exactly know about the octet-stream but the server returns a 500.
i think the stream has to be accepted by the server otherwise the request fails.

and you can keep the form-based upload - just check for mime-type and go from there ...
either multi-part or stream-based.

as for the success param, couldn't you just add this to the "regular" returned JSON (https://github.com/MOLIS/api-documentation/blob/master/post-images.md)? ... you already have an error param if request fails.

[aronwoost]

Will check re stream.

Ok, you're speaking about a success after all uploads are finished. Certainly possible, although I hesitate to add to much vendor specific stuff. Shouldn't be status code 2xx be good enough for a library? Anyhow I'll look into it.

[pkyeck]

Ok, you're speaking about a success after all uploads are finished. Certainly possible, although I hesitate to add to much vendor specific stuff.

you're right about the vendor-specific stuff, but I think adding a success param to the normal JSON response should be ok (no additional call needed).

Shouldn't be status code 2xx be good enough for a library?

you also return 2xx if an error occurs, aren't you?!

here is what the fineupload people say about server-side requirements:
https://github.com/valums/file-uploader/blob/master/server/readme.md

[aronwoost]

Ok, I'll have a look.

[aronwoost]

What is the advantage (for the client) of a xhr2 stream upload over a xhr2 FormData POST in the first place?

I'm not sure if this should be implemented in the current endpoint since the stream upload does (of course) not allow mixing meta-data and files (would be possible in the header though).

However, the API is far from being finished. :) What would be the win for a regular front end dev to be able to use stream upload?

(for reference)