Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Is the GRU implementation in consistent with the paper? #5

@my-yy

Description

@my-yy

I read the peephole GRU implementation in models.py :

newgate = F.tanh(i_n + resetgate * h_n + p_n) (line54)
hy = newgate + inputgate * (hidden - newgate) . (line 55 )

Are they in consistent with the (3) and (4) equations in the paper?
I think the line 54 missed the “entrywise product of r_t and h_t-1” and the line 55 also not looks like the equation (4).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions