Skip to content

Module creation and CLI interface cleaning #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Module creation and CLI interface cleaning #4342

wants to merge 5 commits into from
+320 −214

Conversation

@OliverStrait
Copy link
Contributor

@OliverStrait OliverStrait commented Jul 21, 2025 •
edited
Loading

Overview: What does this pull request change?

Cleaning and documenting Runtime module creation and Scene-class search

  • Old version had knowledge of Scene and did had CLI control flow baked in.
  • New version put CLI control flow back into caller file. Module creation does only one job.
  • New functions are type agnostig and generic

Version checker:

  • Old checker connects to internet every time when rendering is stopped
  • New version caches information into file and fetch information from internet only once a day.

Motivation and Explanation: Why and how do your changes improve the library?

  • Code quality and function documentation and typing
  • Little changes to CLI UX.

Related issue

#4264

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Jul 21, 2025
OliverStrait
OliverStrait commented Jul 22, 2025
View reviewed changes
Oliver Strait added 5 commits July 31, 2025 19:23
Cleaner implementation of module and runtime Scene
9e62b2d 
generation.
- Module code does not know manim anymore
- Two CLI helper function in new cli_utils.py
- Commands are only place that has knowledge of
    wider program
- Every CLI choise and desicion is moved inside
    of Commands
Add functionality of cached version number
91c4f3e
Custom api for DearPyGui to process and fetch
a23bc18 
Scene classes
cli_ utils:
8b84a13 
- fixing  typos and added full docstring
- replace regex with python string split
module_ops:
-  full docstrings, typo fixing
- handling python internal type-madness with exceptions to please mypy
commands:
- docstrings, typos, more descriptive names
-  cleaning version fetch functionality
little logic fix.
adfa870 
Use Scene and not type(self)
@henrikmidtiby henrikmidtiby added the typehints For adding/discussing typehints label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

typehints For adding/discussing typehints

Projects

Dev Board
Status: 🆕 New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OliverStrait @henrikmidtiby