From 3a8493f16b8ecf1877021f1bd48ba3ca2d38524e Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Wed, 10 Sep 2025 18:26:30 +0300 Subject: [PATCH 01/18] ci: add action-lint workflow --- .github/workflows/action-lint.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/workflows/action-lint.yaml diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml new file mode 100644 index 0000000..4757111 --- /dev/null +++ b/.github/workflows/action-lint.yaml @@ -0,0 +1,11 @@ +name: reviewdog +on: [pull_request] +jobs: + actionlint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 + with: + github_token: ${{ secrets.GH_PAT }} + reporter: github-pr-review From 614b55b5c18f32caf11d0c37cec4998e8e2c4d12 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Thu, 11 Sep 2025 11:54:46 +0300 Subject: [PATCH 02/18] ci: add action-lint check for actions directory --- .github/workflows/action-lint.yaml | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 4757111..14b29f5 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -1,11 +1,33 @@ name: reviewdog on: [pull_request] jobs: - actionlint: + actionlint-workflows: runs-on: ubuntu-latest steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: - github_token: ${{ secrets.GH_PAT }} + github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review + actionlint-actions: + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v4 + - name: Install actionlint + run: | + version=$(curl -s https://api.github.com/repos/rhysd/actionlint/releases/latest | grep tag_name | cut -d '"' -f4) + curl -sSL "https://github.com/rhysd/actionlint/releases/download/${version}/actionlint_${version#v}_linux_amd64.tar.gz" | tar xz + sudo mv actionlint /usr/local/bin/ + - name: Run actionlint + run: | + find actions -type f \( -name "*.yml" -o -name "*.yaml" \) -print0 | \ + xargs -0 actionlint -format gcc 2>&1 | tee actionlint.log + - name: Install reviewdog + run: | + curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin + - name: Report with reviewdog + env: + REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + cat actionlint.log | reviewdog -efm="%f:%l:%c: %m" -name=actionlint -reporter=github-pr-review -fail-on-error=true From 2707c94bd1102de32ca4383507a75666c4a2b5da Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Thu, 11 Sep 2025 12:36:39 +0300 Subject: [PATCH 03/18] ci: refactor action-lint workflow and fail on error --- .github/workflows/action-lint.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 14b29f5..a56461c 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -9,6 +9,7 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review + fail_level: error actionlint-actions: runs-on: ubuntu-latest steps: @@ -22,7 +23,7 @@ jobs: - name: Run actionlint run: | find actions -type f \( -name "*.yml" -o -name "*.yaml" \) -print0 | \ - xargs -0 actionlint -format gcc 2>&1 | tee actionlint.log + xargs -0 actionlint 2>&1 | tee actionlint.log - name: Install reviewdog run: | curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin @@ -30,4 +31,4 @@ jobs: env: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - cat actionlint.log | reviewdog -efm="%f:%l:%c: %m" -name=actionlint -reporter=github-pr-review -fail-on-error=true + reviewdog -efm="%f:%l:%c: %m" -name=actionlint -reporter=github-pr-review -fail-level=error < actionlint.log From 84a900882349d8494ec07919070e361c49d5d746 Mon Sep 17 00:00:00 2001 From: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com> Date: Sun, 14 Sep 2025 09:27:04 +0300 Subject: [PATCH 04/18] Update .github/workflows/action-lint.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/action-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index a56461c..66e0a21 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -26,7 +26,7 @@ jobs: xargs -0 actionlint 2>&1 | tee actionlint.log - name: Install reviewdog run: | - curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin + curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.17.3/install.sh | sh -s -- -b /usr/local/bin - name: Report with reviewdog env: REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 6a753581dcf5b99fe9387b3a56b5dde3cddde580 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 09:30:52 +0300 Subject: [PATCH 05/18] ci: make sure actions directory exists --- .github/workflows/action-lint.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index a56461c..e2c9a10 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -22,8 +22,13 @@ jobs: sudo mv actionlint /usr/local/bin/ - name: Run actionlint run: | - find actions -type f \( -name "*.yml" -o -name "*.yaml" \) -print0 | \ - xargs -0 actionlint 2>&1 | tee actionlint.log + if [ -d actions ]; then + find actions -type f \( -name "*.yml" -o -name "*.yaml" \) -print0 | \ + xargs -0 actionlint 2>&1 | tee actionlint.log + else + echo "No 'actions' directory found. Skipping actionlint for actions." + exit 1 + fi - name: Install reviewdog run: | curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /usr/local/bin From f95215a12dc2312188b7ec6d378e1de6a806c2dc Mon Sep 17 00:00:00 2001 From: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com> Date: Sun, 14 Sep 2025 09:32:23 +0300 Subject: [PATCH 06/18] Update .github/workflows/action-lint.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/action-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 8ce2613..bbb0c70 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - name: Install actionlint run: | version=$(curl -s https://api.github.com/repos/rhysd/actionlint/releases/latest | grep tag_name | cut -d '"' -f4) From e6cbe5261ea780c990e1bbe08629c0284ef333fa Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 09:53:21 +0300 Subject: [PATCH 07/18] ci: add checksum check for reviewdog --- .github/workflows/action-lint.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index bbb0c70..44503e7 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -17,9 +17,13 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - name: Install actionlint run: | - version=$(curl -s https://api.github.com/repos/rhysd/actionlint/releases/latest | grep tag_name | cut -d '"' -f4) - curl -sSL "https://github.com/rhysd/actionlint/releases/download/${version}/actionlint_${version#v}_linux_amd64.tar.gz" | tar xz - sudo mv actionlint /usr/local/bin/ + set -e + ACTIONLINT_VERSION="v1.7.5" + ACTIONLINT_TAR_FILENAME="actionlint_${ACTIONLINT_VERSION#v}_linux_amd64.tar.gz" + curl -sSL -o ${ACTIONLINT_TAR_FILENAME} "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/${ACTIONLINT_TAR_FILENAME}" + curl -sSL -o checksums.txt "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION#v}_checksums.txt" + grep "${ACTIONLINT_TAR_FILENAME}" checksums.txt | sha256sum -c - + tar xzf ${ACTIONLINT_TAR_FILENAME} - name: Run actionlint run: | if [ -d actions ]; then From f7fcea7ab55ead3f048d55f1fccff1e9a600bf84 Mon Sep 17 00:00:00 2001 From: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com> Date: Sun, 14 Sep 2025 09:57:00 +0300 Subject: [PATCH 08/18] Update .github/workflows/action-lint.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/action-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 44503e7..f0b937d 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -31,7 +31,7 @@ jobs: xargs -0 actionlint 2>&1 | tee actionlint.log else echo "No 'actions' directory found. Skipping actionlint for actions." - exit 1 + exit 0 fi - name: Install reviewdog run: | From ab50056d90419e9fcc1be237f8329ed198f52764 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 09:59:48 +0300 Subject: [PATCH 09/18] chore: add double quotes for variables --- .github/workflows/action-lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index f0b937d..ff3ca66 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -20,10 +20,10 @@ jobs: set -e ACTIONLINT_VERSION="v1.7.5" ACTIONLINT_TAR_FILENAME="actionlint_${ACTIONLINT_VERSION#v}_linux_amd64.tar.gz" - curl -sSL -o ${ACTIONLINT_TAR_FILENAME} "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/${ACTIONLINT_TAR_FILENAME}" + curl -sSL -o "${ACTIONLINT_TAR_FILENAME}" "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/${ACTIONLINT_TAR_FILENAME}" curl -sSL -o checksums.txt "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION#v}_checksums.txt" grep "${ACTIONLINT_TAR_FILENAME}" checksums.txt | sha256sum -c - - tar xzf ${ACTIONLINT_TAR_FILENAME} + tar xzf "${ACTIONLINT_TAR_FILENAME}" - name: Run actionlint run: | if [ -d actions ]; then From 4057f192bcf8e7734f86a53f77119d2927408547 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 14:35:39 +0300 Subject: [PATCH 10/18] refactor: build yaml files list and pass to reviewdog as actionlint flags --- .github/workflows/action-lint.yaml | 38 +++++++++--------------------- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index ff3ca66..0a17e33 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -13,31 +13,15 @@ jobs: actionlint-actions: runs-on: ubuntu-latest steps: - - name: Checkout repository - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - name: Install actionlint - run: | - set -e - ACTIONLINT_VERSION="v1.7.5" - ACTIONLINT_TAR_FILENAME="actionlint_${ACTIONLINT_VERSION#v}_linux_amd64.tar.gz" - curl -sSL -o "${ACTIONLINT_TAR_FILENAME}" "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/${ACTIONLINT_TAR_FILENAME}" - curl -sSL -o checksums.txt "https://github.com/rhysd/actionlint/releases/download/${ACTIONLINT_VERSION}/actionlint_${ACTIONLINT_VERSION#v}_checksums.txt" - grep "${ACTIONLINT_TAR_FILENAME}" checksums.txt | sha256sum -c - - tar xzf "${ACTIONLINT_TAR_FILENAME}" - - name: Run actionlint - run: | - if [ -d actions ]; then - find actions -type f \( -name "*.yml" -o -name "*.yaml" \) -print0 | \ - xargs -0 actionlint 2>&1 | tee actionlint.log - else - echo "No 'actions' directory found. Skipping actionlint for actions." - exit 0 - fi - - name: Install reviewdog - run: | - curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.17.3/install.sh | sh -s -- -b /usr/local/bin - - name: Report with reviewdog - env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + - name: Build actionlint flags + id: build_flags run: | - reviewdog -efm="%f:%l:%c: %m" -name=actionlint -reporter=github-pr-review -fail-level=error < actionlint.log + files=" $(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" + echo "flags=$files" >> $GITHUB_OUTPUT + - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: github-pr-review + actionlint_flags: ${{ steps.build_flags.outputs.flags }} + fail_level: error From af0709c4da294971f1c58469c2bd9a1b304a13ac Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 14:39:27 +0300 Subject: [PATCH 11/18] chore: double quote parameters --- .github/workflows/action-lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 0a17e33..754adf9 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -17,11 +17,11 @@ jobs: - name: Build actionlint flags id: build_flags run: | - files=" $(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" + files="$(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" echo "flags=$files" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review - actionlint_flags: ${{ steps.build_flags.outputs.flags }} + actionlint_flags: "${{ steps.build_flags.outputs.flags }}" fail_level: error From b8b2f1546443ddefca0e6b644fdbda0701aa8e02 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 14:41:39 +0300 Subject: [PATCH 12/18] chore: double quote parameters --- .github/workflows/action-lint.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 754adf9..991a076 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -18,10 +18,10 @@ jobs: id: build_flags run: | files="$(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" - echo "flags=$files" >> $GITHUB_OUTPUT + echo "flags=\"$files\"" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review - actionlint_flags: "${{ steps.build_flags.outputs.flags }}" + actionlint_flags: ${{ steps.build_flags.outputs.flags }} fail_level: error From 3ac9832a6feefc2dd41bfda54ab69dc6dc078304 Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 14:44:49 +0300 Subject: [PATCH 13/18] chore: remove quotes --- .github/workflows/action-lint.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 991a076..42a7e89 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -18,7 +18,7 @@ jobs: id: build_flags run: | files="$(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" - echo "flags=\"$files\"" >> $GITHUB_OUTPUT + echo "flags=$files" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: github_token: ${{ secrets.GITHUB_TOKEN }} From fcad6d9490a193bd448a4f19f9ef210b9187c94d Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 14 Sep 2025 14:49:50 +0300 Subject: [PATCH 14/18] chore: disable SC2086 shell check for github actions output --- .github/workflows/action-lint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint.yaml index 42a7e89..2e81cf2 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint.yaml @@ -18,6 +18,7 @@ jobs: id: build_flags run: | files="$(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" + # shellcheck disable=SC2086 echo "flags=$files" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: From 1db71a6f2b402829053892f55e9a01d6703f205b Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Wed, 17 Sep 2025 17:39:16 +0300 Subject: [PATCH 15/18] ci: split actionlint to two seperate actions for workflows and actions --- .../{action-lint.yaml => action-lint-actions.yaml} | 9 --------- .github/workflows/action-lint-workflows.yaml | 12 ++++++++++++ 2 files changed, 12 insertions(+), 9 deletions(-) rename .github/workflows/{action-lint.yaml => action-lint-actions.yaml} (66%) create mode 100644 .github/workflows/action-lint-workflows.yaml diff --git a/.github/workflows/action-lint.yaml b/.github/workflows/action-lint-actions.yaml similarity index 66% rename from .github/workflows/action-lint.yaml rename to .github/workflows/action-lint-actions.yaml index 2e81cf2..8c5efeb 100644 --- a/.github/workflows/action-lint.yaml +++ b/.github/workflows/action-lint-actions.yaml @@ -1,15 +1,6 @@ name: reviewdog on: [pull_request] jobs: - actionlint-workflows: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 - with: - github_token: ${{ secrets.GITHUB_TOKEN }} - reporter: github-pr-review - fail_level: error actionlint-actions: runs-on: ubuntu-latest steps: diff --git a/.github/workflows/action-lint-workflows.yaml b/.github/workflows/action-lint-workflows.yaml new file mode 100644 index 0000000..6294800 --- /dev/null +++ b/.github/workflows/action-lint-workflows.yaml @@ -0,0 +1,12 @@ +name: reviewdog +on: [pull_request] +jobs: + actionlint-workflows: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: github-pr-review + fail_level: error From 55b2eff44f1ed4e6315921891d0f0138dee56a22 Mon Sep 17 00:00:00 2001 From: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com> Date: Sun, 21 Sep 2025 00:54:54 +0300 Subject: [PATCH 16/18] Update .github/workflows/action-lint-actions.yaml Co-authored-by: Netanel Cohen <34451523+netanelC@users.noreply.github.com> --- .github/workflows/action-lint-actions.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint-actions.yaml b/.github/workflows/action-lint-actions.yaml index 8c5efeb..2171508 100644 --- a/.github/workflows/action-lint-actions.yaml +++ b/.github/workflows/action-lint-actions.yaml @@ -13,7 +13,7 @@ jobs: echo "flags=$files" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: - github_token: ${{ secrets.GITHUB_TOKEN }} + github_token: ${{ secrets.GH_PAT }} reporter: github-pr-review actionlint_flags: ${{ steps.build_flags.outputs.flags }} fail_level: error From ad9e6b77e9884c35b78af35a12049a2a7003400a Mon Sep 17 00:00:00 2001 From: Shimon Cohen <33935191+shimoncohen@users.noreply.github.com> Date: Sun, 21 Sep 2025 00:55:07 +0300 Subject: [PATCH 17/18] Update .github/workflows/action-lint-workflows.yaml Co-authored-by: Netanel Cohen <34451523+netanelC@users.noreply.github.com> --- .github/workflows/action-lint-workflows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/action-lint-workflows.yaml b/.github/workflows/action-lint-workflows.yaml index 6294800..2678be3 100644 --- a/.github/workflows/action-lint-workflows.yaml +++ b/.github/workflows/action-lint-workflows.yaml @@ -7,6 +7,6 @@ jobs: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 with: - github_token: ${{ secrets.GITHUB_TOKEN }} + github_token: ${{ secrets.GH_PAT }} reporter: github-pr-review fail_level: error From d09055a3089fd3a62f15cedcd1bd252d41fcf81b Mon Sep 17 00:00:00 2001 From: shimoncohen Date: Sun, 21 Sep 2025 01:03:29 +0300 Subject: [PATCH 18/18] ci: run only when updating relevant paths --- .github/workflows/action-lint-actions.yaml | 8 ++++++-- .github/workflows/action-lint-workflows.yaml | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/action-lint-actions.yaml b/.github/workflows/action-lint-actions.yaml index 2171508..2c33d0e 100644 --- a/.github/workflows/action-lint-actions.yaml +++ b/.github/workflows/action-lint-actions.yaml @@ -1,5 +1,9 @@ name: reviewdog -on: [pull_request] +on: + pull_request: + paths: + - "actions/**" + jobs: actionlint-actions: runs-on: ubuntu-latest @@ -8,7 +12,7 @@ jobs: - name: Build actionlint flags id: build_flags run: | - files="$(find actions -type f \( -name '*.yml' -o -name '*.yaml' \) | paste -sd' ' -)" + files="$(find actions -type f \( -name 'action.yml' -o -name 'action.yaml' \) | paste -sd' ' -)" # shellcheck disable=SC2086 echo "flags=$files" >> $GITHUB_OUTPUT - uses: reviewdog/action-actionlint@a5524e1c19e62881d79c1f1b9b6f09f16356e281 # v1.65.2 diff --git a/.github/workflows/action-lint-workflows.yaml b/.github/workflows/action-lint-workflows.yaml index 2678be3..449a287 100644 --- a/.github/workflows/action-lint-workflows.yaml +++ b/.github/workflows/action-lint-workflows.yaml @@ -1,5 +1,9 @@ name: reviewdog -on: [pull_request] +on: + pull_request: + paths: + - ".github/workflows/**" + jobs: actionlint-workflows: runs-on: ubuntu-latest