Skip to content

Incorrect type for roles #6

@Cheaterman

Description

@Cheaterman

Hello MartinThoma, yes it's still me, two years later :-)

Do you happen to know what was the idea behind having only 2-tuples of strings allowed in roles?

role: Optional[Union[Tuple[str, str], Tuple[Tuple[str, str]], str]] = ...,

I think I'd like to replace it with str | list[str] | list[list[str]] | None (or, well, the Union & Optional -based equivalent, for pre-3.10 compatibility, I suppose we still care about that since it's not currently EOL? But your call of course)

Thoughts? I'll probably be making the PR, if you don't like it or have a rationale why it is the way it currently is, then do close & share. :-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions