From 9bd837ccd12ba40a5822c2280ced816b710ad91e Mon Sep 17 00:00:00 2001 From: kreed Date: Thu, 4 Jan 2018 14:48:08 +0000 Subject: [PATCH 1/3] added IDisposable interface to IChromeSession --- source/ChromeDevTools/IChromeSession.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/ChromeDevTools/IChromeSession.cs b/source/ChromeDevTools/IChromeSession.cs index ef5d88e8..24b8a1d6 100644 --- a/source/ChromeDevTools/IChromeSession.cs +++ b/source/ChromeDevTools/IChromeSession.cs @@ -8,7 +8,7 @@ public interface ICommand { } - public interface IChromeSession + public interface IChromeSession : IDisposable { Task> SendAsync(ICommand parameter, CancellationToken cancellationToken); From 09c6d2e92c8d3e543a8647f301e06cbffb9f023e Mon Sep 17 00:00:00 2001 From: kreed Date: Thu, 4 Jan 2018 14:48:33 +0000 Subject: [PATCH 2/3] added CloseSession --- source/ChromeDevTools/IChromeProcess.cs | 2 ++ source/ChromeDevTools/RemoteChromeProcess.cs | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/source/ChromeDevTools/IChromeProcess.cs b/source/ChromeDevTools/IChromeProcess.cs index b6d62423..b3b2f9c1 100644 --- a/source/ChromeDevTools/IChromeProcess.cs +++ b/source/ChromeDevTools/IChromeProcess.cs @@ -9,6 +9,8 @@ public interface IChromeProcess : IDisposable Task StartNewSession(); + Task CloseSession(string sessionId); + Uri RemoteDebuggingUri { get; } } } \ No newline at end of file diff --git a/source/ChromeDevTools/RemoteChromeProcess.cs b/source/ChromeDevTools/RemoteChromeProcess.cs index 6c061ae7..532c2076 100644 --- a/source/ChromeDevTools/RemoteChromeProcess.cs +++ b/source/ChromeDevTools/RemoteChromeProcess.cs @@ -43,5 +43,10 @@ public async Task StartNewSession() string json = await http.GetStringAsync("/json/new"); return JsonConvert.DeserializeObject(json); } + + public async Task CloseSession(string sessionId) + { + await http.GetAsync($"/json/close/{sessionId}"); + } } } \ No newline at end of file From 6757aa0d4ea50a8a51e4315f2ae4b57c8f1aa00f Mon Sep 17 00:00:00 2001 From: kreed Date: Thu, 4 Jan 2018 15:36:29 +0000 Subject: [PATCH 3/3] fixed build --- source/ChromeDevTools/MasterDevs.ChromeDevTools.Core.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/ChromeDevTools/MasterDevs.ChromeDevTools.Core.csproj b/source/ChromeDevTools/MasterDevs.ChromeDevTools.Core.csproj index 198dc156..b7125c57 100644 --- a/source/ChromeDevTools/MasterDevs.ChromeDevTools.Core.csproj +++ b/source/ChromeDevTools/MasterDevs.ChromeDevTools.Core.csproj @@ -1,7 +1,6 @@  - netstandard1.5 netstandard1.5;net45 1.0.3 false @@ -22,6 +21,7 @@ +