pg-cdc-old-syntax multiversion tests #34227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangJunBak
force-pushed
the
jun/multiversion-old-cdc-tests
branch
8 times, most recently
from
745d0b9 to
52b5525
Compare
- Adds helper class for doing 0dt upgrades - Add a multiversion test for pg-cdc-old-syntax - Branch on certain testdrive tests due to incompatible syntax - Change version list filtering for upgrade tests Filter on versions within the previous unskippable major release. This won't work for 26.0.0 since we can't upgrade from 25.1, so we keep the same conditional - Add multi-version upgrade tests for Postgres old CDC to release qualification pipeline
SangJunBak
force-pushed
the
jun/multiversion-old-cdc-tests
branch
from
52b5525 to
0a340ad
Compare
SangJunBak
changed the title
SangJunBak
commented
Nov 21, 2025
Comment on lines
+538
to
+540
| if args.mode == "random": | ||
| random_initial_version = Random(args.seed).choice(compatible_versions) | ||
| versions = [random_initial_version, None] |
Contributor
Author
There was a problem hiding this comment.
Initially I wrote this to test a random upgrade path rather than a random direct upgrade, but the test was taking over 2 hours to run doing so. Decided the path testing didn't add much value to this specific test
def-
reviewed
Nov 24, 2025
| agents: | ||
| queue: hetzner-aarch64-4cpu-8gb | ||
|
|
||
| - id: pg-cdc-old-syntax-multi-version-upgrade-random |
Contributor
There was a problem hiding this comment.
I think these should live in Nightly first, because otherwise we will only catch them breaking once the release candidate is already cut.
def-
approved these changes
Nov 26, 2025
def-
added a commit
to def-/materialize
that referenced
this pull request
Dec 2, 2025
def-
added a commit
to def-/materialize
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details
Motivation
https://github.com/MaterializeInc/database-issues/issues/9869
Added these tests in the release qualification pipeline
https://buildkite.com/materialize/release-qualification/builds/1005
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.